Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751297AbdH1FV3 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Aug 2017 01:21:29 -0400
Received: from mail-wm0-f65.google.com ([74.125.82.65]:33776 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750871AbdH1FVZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Aug 2017 01:21:25 -0400
Subject: Re: [PATCH v2 RESEND 1/2] dt-bindings: serial: 8250: Add MediaTek
 BTIF controller bindings
To: Sean Wang <sean.wang@mediatek.com>
Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org, jslaby@suse.com,
        andriy.shevchenko@linux.intel.com, robert.jarzmik@free.fr,
        arnd@arndb.de, p.zabel@pengutronix.de, joel@jms.id.au,
        david@lechnology.com, jan.kiszka@siemens.com,
        heikki.krogerus@linux.intel.com, hpeter@gmail.com, vigneshr@ti.com,
        tthayer@opensource.altera.com, devicetree@vger.kernel.org,
        linux-mediatek@lists.infradead.org, linux-serial@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <cover.1503165144.git.sean.wang@mediatek.com>
 <29b52a3b95982f1097766d515aae09c57e11b002.1503165144.git.sean.wang@mediatek.com>
 <8548a72a-4bf3-d44a-6d26-d64721cffe85@gmail.com>
 <1503862785.19230.76.camel@mtkswgap22>
From: Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <13f6d052-0fad-e99f-2c87-6a98035787cf@gmail.com>
Date: Mon, 28 Aug 2017 08:21:20 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1503862785.19230.76.camel@mtkswgap22>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2233
Lines: 57



On 08/27/2017 10:39 PM, Sean Wang wrote:
> On Sun, 2017-08-27 at 22:00 +0300, Matthias Brugger wrote:
>>
>> On 08/19/2017 09:06 PM, sean.wang@mediatek.com wrote:
>>> From: Sean Wang <sean.wang@mediatek.com>
>>>
>>> Document the devicetree bindings in 8250.txt for MediaTek BTIF
>>> controller which could be found on MT7622 and MT7623 SoC.
>>>
>>> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
>>> ---
>>>    Documentation/devicetree/bindings/serial/8250.txt | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/serial/8250.txt b/Documentation/devicetree/bindings/serial/8250.txt
>>> index 419ff6c..7528d90 100644
>>> --- a/Documentation/devicetree/bindings/serial/8250.txt
>>> +++ b/Documentation/devicetree/bindings/serial/8250.txt
>>> @@ -14,6 +14,9 @@ Required properties:
>>>    	  tegra132, or tegra210.
>>>    	- "nxp,lpc3220-uart"
>>>    	- "ralink,rt2880-uart"
>>> +	- For MediaTek MT7623, must contain "mediatek,mt7623-btif"
>>> +	- For other MediaTek SoCs , must contain "mediatek,<chip>-btif",
>>> +	  "mediatek,mt7623-btif" where <chip> is mt7622.
>>
>> Hm, to me that's confusing. What about:
>> "mediatek,mt7623-btif": for MediaTek MT7623
>> "mediatek,mt7622-btif", "mediatek,mt7623-btif": for MediaTek MT7622
>>
>> If in the future we have more SoCs that support the BTIF, we should add them
>> like the mt7622 case.
>>
> 
> I had v3, but it should have similar logic and also got ack from Rob
> 
> I knew all your logic of adding binding document for all MediaTek
> devices, even I alway added MediaTek device in dt-bindings as the way
> you mentioned here, but I felt this way is fine for this kind of
> dedicated document.
> 
> The reason i don't add it as usual is the following. 8250.txt is common
> and shared among all uart like devices, so i don't want btif device
> occupies too much section and bloat the document when every new MediaTek
> SoC is introduced.
> 
> So instead I refer to existing Nvidia device added in 8250.txt  which I
> thought its way is simple, elegant and also using pattern I can use to
> add btif devices.
> 

Working on my email backlog after vactions I didn't see that this was accepted 
by Rob. Sorry for the noise.

Matthias