Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751208AbdH1GGT (ORCPT ); Mon, 28 Aug 2017 02:06:19 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:24615 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbdH1GGS (ORCPT ); Mon, 28 Aug 2017 02:06:18 -0400 Date: Mon, 28 Aug 2017 09:05:45 +0300 From: Dan Carpenter To: "Waskiewicz Jr, Peter" Cc: SF Markus Elfring , "netdev@vger.kernel.org" , Evgeniy Polyakov , LKML , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry() Message-ID: <20170828060545.yddjpqzitw46lgiu@mwanda> References: <7b206228-b3e9-5cb9-873c-75b5d8aae23b@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 26 On Sun, Aug 27, 2017 at 11:16:06PM +0000, Waskiewicz Jr, Peter wrote: > On 8/27/17 3:26 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Sun, 27 Aug 2017 21:18:37 +0200 > > > > Omit an extra message for a memory allocation failure in this function. > > > > This issue was detected by using the Coccinelle software. > > Did coccinelle trip on the message or the fact you weren't returning NULL? > You've misread the patch somehow. The existing code has a NULL return and it's preserved in Markus's patch. This sort of patch is to fix a checkpatch.pl warning. The error message from this kzalloc() isn't going to get printed because it's a small allocation and small allocations always succeed in current kernels. But probably the main reason checkpatch complains is that kmalloc() already prints a stack trace and a bunch of other information so the printk doesn't add anyting. Removing it saves a little memory. I'm mostly a fan of running checkpatch on new patches or staging and not on old code... regards, dan carpenter