Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751997AbdH1IIE (ORCPT ); Mon, 28 Aug 2017 04:08:04 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:32986 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbdH1IIA (ORCPT ); Mon, 28 Aug 2017 04:08:00 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nikhil Mahale , Daniel Vetter Subject: [PATCH 4.12 53/99] drm: Fix framebuffer leak Date: Mon, 28 Aug 2017 10:04:51 +0200 Message-Id: <20170828080458.122302001@linuxfoundation.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170828080455.968552605@linuxfoundation.org> References: <20170828080455.968552605@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 30 4.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nikhil Mahale commit 491ab4700d1b64f5cf2f9055e01613a923df5fab upstream. Do not leak framebuffer if client provided crtc id found invalid. Signed-off-by: Nikhil Mahale Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/1502250781-5779-1-git-send-email-nmahale@nvidia.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/drm_plane.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -601,6 +601,7 @@ int drm_mode_setplane(struct drm_device crtc = drm_crtc_find(dev, plane_req->crtc_id); if (!crtc) { + drm_framebuffer_put(fb); DRM_DEBUG_KMS("Unknown crtc ID %d\n", plane_req->crtc_id); return -ENOENT;