Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753103AbdH1IvQ (ORCPT ); Mon, 28 Aug 2017 04:51:16 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36698 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752852AbdH1IvM (ORCPT ); Mon, 28 Aug 2017 04:51:12 -0400 Date: Mon, 28 Aug 2017 10:51:08 +0200 From: Daniel Vetter To: Xinliang Liu Cc: Peter Griffin , seanpaul@google.com, Guodong Xu , Feng Chen , Linux Kernel Mailing List , dri-devel , "Liuxinliang (Matthew Liu)" , XinWei Kong , stable@vger.kernel.org, Rongrong Zou , Andrey Konovalov , LAKML Subject: Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured. Message-ID: <20170828085108.zp4pjkmt6gbewwgm@phenom.ffwll.local> Mail-Followup-To: Xinliang Liu , Peter Griffin , seanpaul@google.com, Guodong Xu , Feng Chen , Linux Kernel Mailing List , dri-devel , "Liuxinliang (Matthew Liu)" , XinWei Kong , stable@vger.kernel.org, Rongrong Zou , Andrey Konovalov , LAKML References: <1502806465-17772-1-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 4.11.0-2-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2810 Lines: 87 On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote: > Hi, > > On 15 August 2017 at 22:14, Peter Griffin wrote: > > > This patch fixes the following soft lockup: > > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307] > > > > On weston idle-timeout the IP is powered down and reset > > asserted. On weston resume we get a massive vblank > > IRQ storm due to the LDI registers having lost some state. > > > > This state loss is caused by ade_crtc_atomic_begin() not > > calling ade_ldi_set_mode(). With this patch applied > > resuming from Weston idle-timeout works well. > > > > Signed-off-by: Peter Griffin > > Tested-by: John Stultz > > > > ​​Thanks Peter, > This patch looks good to me. > Reviewed-by: Xinliang Liu ​ > > @Sean, could you please help to apply to drm-misc if others has no more > comments, thanks. hisilicon isn't maintained in drm-misc, and you're the maintainer. This is not how it works. So either a) pick up the patch and send out a pull request to Dave Airlie b) move hisilicon over to drm-misc and become a drm-misc maintainer yourself. This needs a MAINTAINERS update to point the git tree at drm-misc. drm-misc maintainers don't maintain everyone else's driver as a service, that simply doesn't scale. Thanks, Daniel > > Thanks, > Xinliang > ​ > > > Cc: stable@vger.kernel.org > > --- > > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c > > b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c > > index c96c228..72c6357 100644 > > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c > > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c > > @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc > > *crtc, > > { > > struct ade_crtc *acrtc = to_ade_crtc(crtc); > > struct ade_hw_ctx *ctx = acrtc->ctx; > > + struct drm_display_mode *mode = &crtc->state->mode; > > + struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode; > > > > if (!ctx->power_on) > > (void)ade_power_up(ctx); > > + ade_ldi_set_mode(acrtc, mode, adj_mode); > > } > > > > static void ade_crtc_atomic_flush(struct drm_crtc *crtc, > > -- > > 2.7.4 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch