Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbdH1JxH (ORCPT ); Mon, 28 Aug 2017 05:53:07 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5475 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbdH1JxF (ORCPT ); Mon, 28 Aug 2017 05:53:05 -0400 Subject: Re: [PATCH] f2fs: collect prefree segments to avoild write checkpoint fail To: Yunlong Song , , , CC: , , , , References: <1503748019-152845-1-git-send-email-yunlong.song@huawei.com> From: Chao Yu Message-ID: Date: Mon, 28 Aug 2017 17:52:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1503748019-152845-1-git-send-email-yunlong.song@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090201.59A3E7F8.006E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 25216c38c74d24a448395d648ad877c0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1016 Lines: 36 Hi Yunlong, On 2017/8/26 19:46, Yunlong Song wrote: > In come corner case, the reserved segments are used to do gc, and there are > not enough free segments for write checkpoint to finish its job, then the > gc process will fail to change the prefree segments to free segments. How about doing investigate that why we haven't enough free segment for GC? Thanks, > > Signed-off-by: Yunlong Song > --- > fs/f2fs/gc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index cd147e7..c8a828f 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -1056,6 +1056,13 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, > if (!sync) { > if (has_not_enough_free_secs(sbi, sec_freed, 0)) { > segno = NULL_SEGNO; > + if (prefree_segments(sbi) && > + has_not_enough_free_secs(sbi, > + reserved_sections(sbi), 0)) { > + ret = write_checkpoint(sbi, &cpc); > + if (ret) > + goto stop; > + } > goto gc_more; > } > >