Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751848AbdH1KTr (ORCPT ); Mon, 28 Aug 2017 06:19:47 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33802 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768AbdH1KTk (ORCPT ); Mon, 28 Aug 2017 06:19:40 -0400 Date: Mon, 28 Aug 2017 12:19:39 +0200 From: Johan Hovold To: "Maciej S. Szmigiero" Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: add support for D-Link DWM-157 C1 Message-ID: <20170828101939.GD20634@localhost> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1766 Lines: 40 On Mon, Aug 21, 2017 at 05:43:46PM +0200, Maciej S. Szmigiero wrote: > This commit adds support (IDs, really) for D-Link DWM-157 hardware version > C1 USB modem to option driver. > > According to manufacturer-provided Windows INF file the device has four > serial ports: > "D-Link HSPA+DataCard Diagnostics Interface" (interface 2; modem port), > "D-Link HSPA+DataCard NMEA Device" (interface 3), > "D-Link HSPA+DataCard Speech Port" (interface 4), > "D-Link HSPA+DataCard Debug Port" (interface 5). > > Signed-off-by: Maciej S. Szmigiero > Cc: stable@vger.kernel.org > --- > drivers/usb/serial/option.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index fe123153b1a5..fa887c6e50e7 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -2023,6 +2023,8 @@ static const struct usb_device_id option_ids[] = { > { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x02, 0x01) }, > { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x00, 0x00) }, > { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d04, 0xff) }, /* D-Link DWM-158 */ > + { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d0e, 0xff, 0x02, 0x01) }, /* D-Link DWM-157 C1 */ > + { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d0e, 0xff, 0x00, 0x00) }, What is the reason for not using a single USB_DEVICE_INTERFACE_CLASS here instead? Do you have access to this device so that you could post the output of usb-devices (or "lsusb -v")? > { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e19, 0xff), /* D-Link DWM-221 B1 */ > .driver_info = (kernel_ulong_t)&net_intf4_blacklist }, > { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e35, 0xff), /* D-Link DWM-222 */ Thanks, Johan