Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbdH1KxF (ORCPT ); Mon, 28 Aug 2017 06:53:05 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34002 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbdH1KxE (ORCPT ); Mon, 28 Aug 2017 06:53:04 -0400 MIME-Version: 1.0 In-Reply-To: <20170828065553.gikwc5zsuy2762eg@hirez.programming.kicks-ass.net> References: <1503650463-14582-1-git-send-email-byungchul.park@lge.com> <20170828065553.gikwc5zsuy2762eg@hirez.programming.kicks-ass.net> From: Byungchul Park Date: Mon, 28 Aug 2017 19:53:02 +0900 Message-ID: Subject: Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks To: Peter Zijlstra Cc: Byungchul Park , Tejun Heo , johannes.berg@intel.com, Ingo Molnar , Thomas Gleixner , "linux-kernel@vger.kernel.org" , kernel-team@lge.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1191 Lines: 34 On Mon, Aug 28, 2017 at 3:55 PM, Peter Zijlstra wrote: > On Fri, Aug 25, 2017 at 05:41:03PM +0900, Byungchul Park wrote: >> Hello all, >> >> This is _RFC_. >> >> I want to request for comments about if it's reasonable conceptually. If >> yes, I want to resend after working it more carefully. >> >> Could you let me know your opinions about this? >> >> ----->8----- >> From 448360c343477fff63df766544eec4620657a59e Mon Sep 17 00:00:00 2001 >> From: Byungchul Park >> Date: Fri, 25 Aug 2017 17:35:07 +0900 >> Subject: [RFC] workqueue: remove manual lockdep uses to detect deadlocks >> >> We introduced the following commit to detect deadlocks caused by >> wait_for_completion() in flush_{workqueue, work}() and other locks. But >> now LOCKDEP_COMPLETIONS is introduced, such works are automatically done >> by LOCKDEP_COMPLETIONS. So it doesn't have to be done manually anymore. >> Removed it. >> > > No.. the existing annotation is strictly better because it will _always_ > warn. It doesn't need to first observe things just right. Right. That is exactly why I replied to TJ like: https://lkml.org/lkml/2017/8/25/490 -- Thanks, Byungchul