Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbdH1LBw (ORCPT ); Mon, 28 Aug 2017 07:01:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:33780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbdH1LBt (ORCPT ); Mon, 28 Aug 2017 07:01:49 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C88A221A2F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 28 Aug 2017 07:01:46 -0400 From: Steven Rostedt To: Zhou Chengming Cc: , Subject: Re: [PATCH] tracing: make dynamic types can use __TRACE_LAST_TYPE Message-ID: <20170828070146.16d65ca0@gandalf.local.home> In-Reply-To: <1503896348-134351-1-git-send-email-zhouchengming1@huawei.com> References: <1503896348-134351-1-git-send-email-zhouchengming1@huawei.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 729 Lines: 19 On Mon, 28 Aug 2017 12:59:08 +0800 Zhou Chengming wrote: > Obviously, trace_events that defined staticly in trace.h won't use > __TRACE_LAST_TYPE, so make dynamic types can use it. And some > minor changes to trace_search_list() to make code clearer. Is there some reason to do this? I'm not sure it makes the code any clearer. It looks like churn for churn sake. Which means that it can cause a bug, and requires a bit of work to verify it does not. Now if there's other work that is being done that requires this change, then I have no problem adding it. But if it is just to "make it clearer" then no, I'm not adding it. -- Steve > > Signed-off-by: Zhou Chengming