Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751523AbdH1LrM (ORCPT ); Mon, 28 Aug 2017 07:47:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45422 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbdH1LrK (ORCPT ); Mon, 28 Aug 2017 07:47:10 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 35CCD60300 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=aneela@codeaurora.org Subject: Re: [PATCH v2 06/20] rpmsg: glink: Return -EAGAIN when there is no FIFO space To: Sricharan R , ohad@wizery.com, bjorn.andersson@linaro.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1503559302-3744-1-git-send-email-sricharan@codeaurora.org> <1503559302-3744-7-git-send-email-sricharan@codeaurora.org> From: Arun Kumar Neelakantam Message-ID: Date: Mon, 28 Aug 2017 17:17:04 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1503559302-3744-7-git-send-email-sricharan@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 873 Lines: 30 On 8/24/2017 12:51 PM, Sricharan R wrote: > The TX FIFO can be full, if the remote client has > not read enough data (or) reading it slowly. So its > nessecary to return -EAGAIN to the local client to > enable retry. > > Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N > --- > drivers/rpmsg/qcom_glink_native.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c > index a6394cd..94b79e8 100644 > --- a/drivers/rpmsg/qcom_glink_native.c > +++ b/drivers/rpmsg/qcom_glink_native.c > @@ -233,7 +233,7 @@ static int qcom_glink_tx(struct qcom_glink *glink, > > while (qcom_glink_tx_avail(glink) < tlen) { > if (!wait) { > - ret = -ENOMEM; > + ret = -EAGAIN; > goto out; > } >