Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbdH1Lro (ORCPT ); Mon, 28 Aug 2017 07:47:44 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46564 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbdH1Lrl (ORCPT ); Mon, 28 Aug 2017 07:47:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 93BA860234 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=aneela@codeaurora.org Subject: Re: [PATCH v2 07/20] rpmsg: glink: Do a mbox_free_channel in remove To: Sricharan R , ohad@wizery.com, bjorn.andersson@linaro.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1503559302-3744-1-git-send-email-sricharan@codeaurora.org> <1503559302-3744-8-git-send-email-sricharan@codeaurora.org> From: Arun Kumar Neelakantam Message-ID: <1e8c40a7-526f-92ce-e7f7-ee751e5502c7@codeaurora.org> Date: Mon, 28 Aug 2017 17:17:34 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1503559302-3744-8-git-send-email-sricharan@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 25 On 8/24/2017 12:51 PM, Sricharan R wrote: > mbox_request_channel is done in probe, so free the > channel in remove. > > Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N > --- > drivers/rpmsg/qcom_glink_native.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c > index 94b79e8..21adde3 100644 > --- a/drivers/rpmsg/qcom_glink_native.c > +++ b/drivers/rpmsg/qcom_glink_native.c > @@ -1008,4 +1008,5 @@ void qcom_glink_native_remove(struct qcom_glink *glink) > > idr_destroy(&glink->lcids); > idr_destroy(&glink->rcids); > + mbox_free_channel(glink->mbox_chan); > }