Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751353AbdH1Lsr (ORCPT ); Mon, 28 Aug 2017 07:48:47 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47878 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbdH1Lsp (ORCPT ); Mon, 28 Aug 2017 07:48:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9A039603D2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=aneela@codeaurora.org Subject: Re: [PATCH v2 09/20] rpmsg: glink: Fix default case while handling received commands To: Sricharan R , ohad@wizery.com, bjorn.andersson@linaro.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1503559302-3744-1-git-send-email-sricharan@codeaurora.org> <1503559302-3744-10-git-send-email-sricharan@codeaurora.org> From: Arun Kumar Neelakantam Message-ID: <474616a7-5c90-c30a-1692-4c2dc66d1caf@codeaurora.org> Date: Mon, 28 Aug 2017 17:18:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1503559302-3744-10-git-send-email-sricharan@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 28 On 8/24/2017 12:51 PM, Sricharan R wrote: > Currently if we receive a command that we still do not > support, then its simply discarded. While doing so, the > RX FIFO pointer also needs to be incremented. Fixing this. > > Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N > --- > drivers/rpmsg/qcom_glink_native.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c > index 50a8008..9a58925 100644 > --- a/drivers/rpmsg/qcom_glink_native.c > +++ b/drivers/rpmsg/qcom_glink_native.c > @@ -541,6 +541,7 @@ static irqreturn_t qcom_glink_native_intr(int irq, void *data) > ret = 0; > break; > default: > + qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8)); > dev_err(glink->dev, "unhandled rx cmd: %d\n", cmd); > ret = -EINVAL; > break;