Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751318AbdH1MMV (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Aug 2017 08:12:21 -0400
Received: from mx2.suse.de ([195.135.220.15]:47052 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751294AbdH1MMU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Aug 2017 08:12:20 -0400
Message-ID: <1503922153.7477.13.camel@suse.com>
Subject: Re: Possible null pointer dereference in adutux.ko
From: Oliver Neukum <oneukum@suse.com>
To: Anton Volkov <avolkov@ispras.ru>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>, johan@kernel.org,
        gregkh@linuxfoundation.org, ldv-project@linuxtesting.org,
        wsa-dev@sang-engineering.com, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Date: Mon, 28 Aug 2017 14:09:13 +0200
In-Reply-To: <d15c326f-a060-c0e3-b35e-10d02a2c4623@ispras.ru>
References: <fc719c9c-db6a-9254-2d6d-918946c5a18d@ispras.ru>
         <1502803217.6606.3.camel@suse.com>
         <72416d59-5d6d-b499-0373-489e846b2643@ispras.ru>
         <1502812735.6606.6.camel@suse.com>
         <d15c326f-a060-c0e3-b35e-10d02a2c4623@ispras.ru>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3292
Lines: 93

Am Freitag, den 18.08.2017, 18:04 +0300 schrieb Anton Volkov:
> 
> On 15.08.2017 18:58, Oliver Neukum wrote:
> > 
> > Am Dienstag, den 15.08.2017, 16:38 +0300 schrieb Anton Volkov:
> > > 
> > > On 15.08.2017 16:20, Oliver Neukum wrote:
> > > > 
> > > > 
> > > > Am Dienstag, den 15.08.2017, 15:59 +0300 schrieb Anton Volkov:
> > > > > 
> > > > > 
> > > > > Hello.
> > > > > 
> > > > > While searching for races in the Linux kernel I've come across
> > > > > "drivers/usb/misc/adutux.ko" module. Here is a question that I came up
> > > > > with while analyzing results. Lines are given using the info from Linux
> > > > > v4.12.
> > > > > 
> > > > > Consider the following case:
> > > > > 
> > > > > Thread 1:                   Thread 2:
> > > > > adu_release
> > > > > ->adu_release_internal      adu_disconnect
> > > > >        <READ &dev->udev->dev>    dev->udev = NULL
> > > > >        (adutux.c: line 298)      (adutux.c: line 771)
> > > > >                                  usb_deregister_dev
> > > > > 
> > > > > Comments in the source code point at the possibility of adu_release()
> > > > > being called separately from adu_disconnect(). adu_release() and
> > > > > adu_disconnect() acquire different mutexes, so they are not protected
> > > > > from one another. If adu_disconnect() changes dev->udev before its value
> > > > > is read in adu_release_internal() there will be a NULL pointer
> > > > > dereference on a read attempt. Is this case feasible from your point of
> > > > > view?
> > > > > 
> > > > > Thank you for your time.
> > > > 
> > > > Hi,
> > > > 
> > > > your analysis seems correct to me. In fact it looks like
> > > > 
> > > > 66d4bc30d128e7c7ac4cf64aa78cb76e971cec5b
> > > > USB: adutux: remove custom debug macro
> > > > 
> > > > more or less broke disconnect on this driver
> > > > (the URBs can also finish after dev->udev = NULL)
> > > > 
> > > > Do you want to do a fix or do you want me to do it?
> > > > 
> > > > 	Regards
> > > > 		Oliver
> > > > 
> > > 
> > > Hello, Oliver.
> > > 
> > > I am not sure about the best way to solve this problem. If you have any
> > > ideas about it then it would probably be better if you could handle the
> > > fix. Or if you share the ideas I can prepare a patch.
> > 
> > Hi,
> > 
> > given the age of the drivers I would suggest to simply remove the debugging statements
> > 
> > 	Regards
> > 		Oliver
> > 
> 
> Hello, Oliver.
> 
> Looks like deletion of lots of debug print won't solve the race problem 
> because there are other places that could potentially try to dereference 
> dev->udev when disconnect has already poisoned it. For example in 
> adu_open there are calls to usb_fill_int_urb with dev->udev as a 
> parameter to be dereferenced inside the function.

Yes, you are right.

> There are other possible solutions, if I understand correctly:
> 1) although it is described that adutux_mutex should be used to protect 
> only open_count, it usually protects the whole body of a function, so we 
> could probably place it before the locking of dev->mtx;

It seems to me that disconnect, open and release must take both
mutexes.

> 2) move poisoning of dev->udev after usb_deregister_dev in order to wait 
> for all other callbacks to finish.

That would defeat the purpose of poisoning.

	Regards
		Oliver