Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbdH1Nft (ORCPT ); Mon, 28 Aug 2017 09:35:49 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:34921 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbdH1Nfr (ORCPT ); Mon, 28 Aug 2017 09:35:47 -0400 From: Philipp Reisner To: Jens Axboe Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com Subject: Re: [PATCH 01/17] drbd: introduce drbd_recv_header_maybe_unplug Date: Mon, 28 Aug 2017 15:35:44 +0200 Message-ID: <5783324.F96FteIkt8@fat-tyre> In-Reply-To: References: <1503609794-13233-1-git-send-email-philipp.reisner@linbit.com> <1503609794-13233-2-git-send-email-philipp.reisner@linbit.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 480 Lines: 14 Am Freitag, 25. August 2017, 19:26:20 CEST schrieb Jens Axboe: > On 08/24/2017 03:22 PM, Philipp Reisner wrote: > > +#ifndef blk_queue_plugged > > +struct drbd_plug_cb { > > + struct blk_plug_cb cb; > > + struct drbd_request *most_recent_req; > > + /* do we need more? */ > > +}; > > What is this blk_queue_plugged ifdef? Facepalm. That escaped from out out-of-tree code. It has compat code so that it can be compiled with older (distro) kernels. I will resend it without that.