Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751953AbdH1PRW (ORCPT ); Mon, 28 Aug 2017 11:17:22 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48410 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbdH1PRO (ORCPT ); Mon, 28 Aug 2017 11:17:14 -0400 Date: Mon, 28 Aug 2017 17:17:20 +0200 From: Greg Kroah-Hartman To: Marcus Wolf Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: Send a large patch right now or is it better to do it later? Message-ID: <20170828151719.GA28115@kroah.com> References: <20170728132339.332897-1-arnd@arndb.de> <569585967.8859.1501251665326@ox.hosteurope.de> <20170728142636.e6vzzwhc53mv6qpt@mwanda> <643844683.9182.1501255016794@ox.hosteurope.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <643844683.9182.1501255016794@ox.hosteurope.de> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1169 Lines: 30 On Fri, Jul 28, 2017 at 05:16:56PM +0200, Marcus Wolf wrote: > Hi Greg, > > according to the proposals of Walter Harms, I revised the rf69.c: I replaced > some macros with inline functions and removed some obsolete ifdefs. According to > walter this will improve the resource situation. In addition the readybility is > enhanced, since lines got shorter. It's a quite big change, that touched nearly > every function in that file. > I was testing the new code for a while now and did not observer a problem so > far. But I don't have a kind of unit test, so my tests for sure didn't cover > everything. > > Is it a good time, to submit such a change in these days, or is it prefrable to > submit it later? > In adition, I am a bit afraid of my current mailtool doing something > unexpected... You can send patches anytime, don't worry about timing, I can handle putting them in the correct patch queue. > P.S. Can you process diffs fom SVN, too, or is it mandatory to create the diff > with git? As long as it is in normal patch format, I can apply it. Personally, I use quilt to generate patche, which uses 'diff', and that works just fine. thanks, greg k-h