Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751822AbdH1PQb (ORCPT ); Mon, 28 Aug 2017 11:16:31 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:36461 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751745AbdH1PQ1 (ORCPT ); Mon, 28 Aug 2017 11:16:27 -0400 Date: Mon, 28 Aug 2017 08:16:24 -0700 From: Stephen Hemminger To: Eduardo Otubo Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, Haiyang Zhang , Stephen Hemminger , David Miller Subject: Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip Message-ID: <20170828081624.16a1e4de@xeon-e3> In-Reply-To: <20170828100121.17321-1-otubo@redhat.com> References: <20170828100121.17321-1-otubo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 18 On Mon, 28 Aug 2017 12:01:21 +0200 Eduardo Otubo wrote: > v2: The script is now a little bit safer so it doesn't conflicts with > network daemon trying to set configurations at the same time. > > This patch fixes the behavior of the hv_set_ifconfig script when setting > the interface ip. Sometimes the interface has already been configured by > network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file > exists error"; in order to avoid this error this patch makes sure double > checks the interface before trying anything. > > Signed-off-by: Eduardo Otubo Adding new dependency on systemd is not going to make this script even less useful. I wonder why the script still exists at all? Most of the Linux distro's can already setup HV networking without it.