Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbdH1Pqj (ORCPT ); Mon, 28 Aug 2017 11:46:39 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:30102 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbdH1Pqh (ORCPT ); Mon, 28 Aug 2017 11:46:37 -0400 X-IronPort-AV: E=Sophos;i="5.41,442,1498492800"; d="scan'208";a="148456289" From: Bart Van Assche To: "linux-scsi@vger.kernel.org" , "alim.akhtar@samsung.com" , "linux-kernel@vger.kernel.org" CC: "martin.petersen@oracle.com" , "JBottomley@odin.com" , "vinholikatti@gmail.com" Subject: Re: [PATCH] scsi: ufs: Make use of UFS_BIT macro wherever possible Thread-Topic: [PATCH] scsi: ufs: Make use of UFS_BIT macro wherever possible Thread-Index: AQHTH/kPxsmrlDWS3EqNJ/VfvdTYNqKZ6XyA Date: Mon, 28 Aug 2017 15:45:49 +0000 Message-ID: <1503935147.2841.25.camel@wdc.com> References: <1503922783-14317-1-git-send-email-alim.akhtar@samsung.com> In-Reply-To: <1503922783-14317-1-git-send-email-alim.akhtar@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1067;20:IRao1tsoTq5FYlKQAtz1UGhD02nL4eXPq4MFM7Ext6H7batkcDX+Tn3/JTcNVwwKfjvyca1LwZeijqX4BgNtQTN+5mDAnC2zjKeyHO7uhkmmMuiqjaI1po/dyII74CvpxsAjNzQpRTclSVK+SV9oS/AHBjqgm/ES42aaBDFGPjk= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 79092755-610c-4950-9ce5-08d4ee2bdb18 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY1PR0401MB1067; x-ms-traffictypediagnostic: CY1PR0401MB1067: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1067;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1067; x-forefront-prvs: 0413C9F1ED x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(24454002)(199003)(377424004)(189002)(72206003)(33646002)(2501003)(39060400002)(5660300001)(86362001)(66066001)(106356001)(105586002)(8676002)(189998001)(81166006)(53936002)(81156014)(54906002)(6506006)(6512007)(77096006)(6486002)(99286003)(7736002)(6246003)(25786009)(6436002)(2950100002)(101416001)(4326008)(305945005)(229853002)(50986999)(76176999)(54356999)(8936002)(3280700002)(97736004)(103116003)(14454004)(3660700001)(2906002)(2900100001)(3846002)(102836003)(2201001)(68736007)(6116002)(478600001)(36756003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1067;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2017 15:45:49.2129 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1067 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7SFkidX002510 Content-Length: 580 Lines: 17 On Mon, 2017-08-28 at 17:49 +0530, Alim Akhtar wrote: > This entire file uses UFS_BIT macro for bits definition, expect for few > places. This patch convert those defines to use UFS_BIT macro to be aligned > with reset of the file. This is the definition of the UFS_BIT() macro I found in drivers/scsi/ufs/ufshci.h: #define UFS_BIT(x) (1L << (x)) Using this macro makes code longer instead of shorter and does not improve code readability. Is this macro really useful? Wouldn't it be better to remove the UFS_BIT() macro instead of introducing more uses of it? Thanks, Bart.