Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751685AbdH1QFr (ORCPT ); Mon, 28 Aug 2017 12:05:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42342 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbdH1QFp (ORCPT ); Mon, 28 Aug 2017 12:05:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 312147CDEA Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=otubo@redhat.com Date: Mon, 28 Aug 2017 18:05:39 +0200 From: Eduardo Otubo To: Haiyang Zhang Cc: Stephen Hemminger , KY Srinivasan , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , Stephen Hemminger , David Miller Subject: Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip Message-ID: <20170828160539.GA9329@vader> References: <20170828100121.17321-1-otubo@redhat.com> <20170828081624.16a1e4de@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3+47 (5f034395e53d) (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 28 Aug 2017 16:05:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1583 Lines: 41 On Mon, Aug 28, 2017 at 03:56:44PM +0000, Haiyang Zhang wrote: > > > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Monday, August 28, 2017 11:16 AM > > To: Eduardo Otubo > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; Haiyang > > Zhang ; Stephen Hemminger > > ; David Miller > > Subject: Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip > > > > On Mon, 28 Aug 2017 12:01:21 +0200 > > Eduardo Otubo wrote: > > > > > v2: The script is now a little bit safer so it doesn't conflicts with > > > network daemon trying to set configurations at the same time. > > > > > > This patch fixes the behavior of the hv_set_ifconfig script when > > setting > > > the interface ip. Sometimes the interface has already been configured > > by > > > network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file > > > exists error"; in order to avoid this error this patch makes sure > > double > > > checks the interface before trying anything. > > > > > > Signed-off-by: Eduardo Otubo > > > > Adding new dependency on systemd is not going to make this script > > even less useful. I wonder why the script still exists at all? Most of > > the > > Linux distro's can already setup HV networking without it. > > Also, this script is meant to run only on RHEL guests, as written on the header of this very same file. -- Eduardo Otubo Senior Software Engineer @ RedHat