Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751582AbdH1Quh (ORCPT ); Mon, 28 Aug 2017 12:50:37 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34567 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbdH1Quf (ORCPT ); Mon, 28 Aug 2017 12:50:35 -0400 Date: Mon, 28 Aug 2017 09:50:31 -0700 From: Dmitry Torokhov To: Alexandre Belloni Cc: Greg Ungerer , Geert Uytterhoeven , linux-m68k@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] input: misc: don't build m68kspkr when mach_beep is undefined Message-ID: <20170828165031.GD12195@dtor-ws> References: <20170824144427.23873-1-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170824144427.23873-1-alexandre.belloni@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 36 On Thu, Aug 24, 2017 at 04:44:27PM +0200, Alexandre Belloni wrote: > mach_beep is defined arch/m68k/kernel/setup_mm.c which is compiled only > when MMU is selected. > > To avoid linking errors, make INPUT_M68K_BEEP depend on MMU. Hmm, can we maybe pull mach_beep from setup_mm.c to setup.c? MMU dependency seems to be artificial. > > Signed-off-by: Alexandre Belloni > --- > drivers/input/misc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig > index 3872488c3fd7..7a44f633a413 100644 > --- a/drivers/input/misc/Kconfig > +++ b/drivers/input/misc/Kconfig > @@ -178,7 +178,7 @@ config INPUT_SPARCSPKR > > config INPUT_M68K_BEEP > tristate "M68k Beeper support" > - depends on M68K > + depends on M68K && MMU > > config INPUT_MAX77693_HAPTIC > tristate "MAXIM MAX77693/MAX77843 haptic controller support" > -- > 2.14.1 > Thanks. -- Dmitry