Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751347AbdH1RPt (ORCPT ); Mon, 28 Aug 2017 13:15:49 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:38753 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbdH1RPs (ORCPT ); Mon, 28 Aug 2017 13:15:48 -0400 MIME-Version: 1.0 In-Reply-To: <20170828165031.GD12195@dtor-ws> References: <20170824144427.23873-1-alexandre.belloni@free-electrons.com> <20170828165031.GD12195@dtor-ws> From: Geert Uytterhoeven Date: Mon, 28 Aug 2017 19:15:46 +0200 X-Google-Sender-Auth: tsBdc5aQnwMGQBbJo3YoRgtgjCY Message-ID: Subject: Re: [PATCH] input: misc: don't build m68kspkr when mach_beep is undefined To: Dmitry Torokhov Cc: Alexandre Belloni , Greg Ungerer , linux-m68k , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 957 Lines: 30 Hi Dmitry, On Mon, Aug 28, 2017 at 6:50 PM, Dmitry Torokhov wrote: > On Thu, Aug 24, 2017 at 04:44:27PM +0200, Alexandre Belloni wrote: >> mach_beep is defined arch/m68k/kernel/setup_mm.c which is compiled only >> when MMU is selected. >> >> To avoid linking errors, make INPUT_M68K_BEEP depend on MMU. > > Hmm, can we maybe pull mach_beep from setup_mm.c to setup.c? MMU Sounds OK to me. Greg? > dependency seems to be artificial. That's indeed artificial, it's really a platform dependency. But currently these platforms (Amiga and Atari) do not support mmu-less operation (yet). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds