Date: Mon, 28 Aug 2017 19:25:40 +0200
From: Borislav Petkov <bp@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Tyler Baicar <tbaicar@codeaurora.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>,
        Will Deacon <will.deacon@arm.com>, james.morse@arm.com,
        shiju.jose@huawei.com, Geliang Tang <geliangtang@gmail.com>,
        Tony Luck <tony.luck@intel.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3] acpi: apei: clear error status before acknowledging
 the error
Message-ID: <20170828172539.5cl7baxdxxaixlri@pd.tnic>
References: <1503939221-27732-1-git-send-email-tbaicar@codeaurora.org>
 <1503939660.25945.127.camel@linux.intel.com>
 <20170828171405.2s4rlebloi5lyhga@pd.tnic>
 <CAHp75Vdx2NG8yd-cr14hxQzEjy-V29de4nbiq0v9tWpXVxt+2w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75Vdx2NG8yd-cr14hxQzEjy-V29de4nbiq0v9tWpXVxt+2w@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 449
Lines: 17

On Mon, Aug 28, 2017 at 08:20:37PM +0300, Andy Shevchenko wrote:
>        if (rc != -ENOENT && is_hest_type_generic_v2(ghes))
>  :-)
> 
> But again, your call to choose :-)

Slow down please.

What do you think is more readable: a compound if-statement or two
simple ones, the second one with an explanatory comment?

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--