Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751546AbdH1SSO (ORCPT ); Mon, 28 Aug 2017 14:18:14 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:38097 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbdH1SSM (ORCPT ); Mon, 28 Aug 2017 14:18:12 -0400 Date: Mon, 28 Aug 2017 20:18:08 +0200 From: Christoffer Dall To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Christoffer Dall , Thomas Gleixner , Jason Cooper , Eric Auger , Shanker Donthineni , Mark Rutland , Shameerali Kolothum Thodi Subject: Re: [PATCH v3 43/59] KVM: arm/arm64: GICv4: Unmap VLPI when freeing an LPI Message-ID: <20170828181808.GC24649@cbox> References: <20170731172637.29355-1-marc.zyngier@arm.com> <20170731172637.29355-44-marc.zyngier@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170731172637.29355-44-marc.zyngier@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1007 Lines: 37 On Mon, Jul 31, 2017 at 06:26:21PM +0100, Marc Zyngier wrote: > When freeing an LPI (on a DISCARD command, for example), we need > to unmap the VLPI down to the physical ITS level. > > Signed-off-by: Marc Zyngier > --- > virt/kvm/arm/vgic/vgic-its.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c > index 40aeadef33fe..79bac93d3e7d 100644 > --- a/virt/kvm/arm/vgic/vgic-its.c > +++ b/virt/kvm/arm/vgic/vgic-its.c > @@ -623,8 +623,12 @@ static void its_free_ite(struct kvm *kvm, struct its_ite *ite) > list_del(&ite->ite_list); > > /* This put matches the get in vgic_add_lpi. */ > - if (ite->irq) > + if (ite->irq) { > + if (ite->irq->hw) > + its_unmap_vlpi(ite->irq->host_irq); nit: should we raise a warning on a bad return value? Otherwise: Acked-by: Christoffer Dall > + > vgic_put_irq(kvm, ite->irq); > + } > > kfree(ite); > } > -- > 2.11.0 >