Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbdH1SkH (ORCPT ); Mon, 28 Aug 2017 14:40:07 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36967 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbdH1SkG (ORCPT ); Mon, 28 Aug 2017 14:40:06 -0400 Reply-To: minyard@acm.org Subject: Re: [PATCH] IPMI: make ipmi_poweroff_handler const To: Bhumika Goyal , julia.lawall@lip6.fr, openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <1503943695-18681-1-git-send-email-bhumirks@gmail.com> From: Corey Minyard Message-ID: Date: Mon, 28 Aug 2017 13:40:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1503943695-18681-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 851 Lines: 27 On 08/28/2017 01:08 PM, Bhumika Goyal wrote: > Make this const as it is only passed to a const argument of the function > ipmi_create_user. Queued for the next kernel release. -corey > Signed-off-by: Bhumika Goyal > --- > drivers/char/ipmi/ipmi_poweroff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c > index 9f2e3be..cd0f41f 100644 > --- a/drivers/char/ipmi/ipmi_poweroff.c > +++ b/drivers/char/ipmi/ipmi_poweroff.c > @@ -133,7 +133,7 @@ static void receive_handler(struct ipmi_recv_msg *recv_msg, void *handler_data) > complete(comp); > } > > -static struct ipmi_user_hndl ipmi_poweroff_handler = { > +static const struct ipmi_user_hndl ipmi_poweroff_handler = { > .ipmi_recv_hndl = receive_handler > }; >