Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751280AbdH1Tuo (ORCPT ); Mon, 28 Aug 2017 15:50:44 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36269 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbdH1Tum (ORCPT ); Mon, 28 Aug 2017 15:50:42 -0400 Date: Mon, 28 Aug 2017 21:50:39 +0200 From: Jiri Pirko To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Andrew Lunn , Egil Hjelmeland , John Crispin , Woojung Huh , Sean Wang , Nikita Yushchenko , Chris Healy Subject: Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface Message-ID: <20170828195039.GA1950@nanopsycho.orion> References: <20170828191748.19492-1-vivien.didelot@savoirfairelinux.com> <20170828191748.19492-2-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170828191748.19492-2-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 31 Mon, Aug 28, 2017 at 09:17:39PM CEST, vivien.didelot@savoirfairelinux.com wrote: >This commit adds a DEBUG_FS dependent DSA core file creating a generic >debug filesystem interface for the DSA switch devices. > >The interface can be mounted with: > > # mount -t debugfs none /sys/kernel/debug > >The dsa directory contains one directory per switch chip: > > # cd /sys/kernel/debug/dsa/ > # ls > switch0 switch1 switch2 > >Each chip directory contains one directory per port: > > # ls -l switch0/ > drwxr-xr-x 2 root root 0 Jan 1 00:00 port0 > drwxr-xr-x 2 root root 0 Jan 1 00:00 port1 > drwxr-xr-x 2 root root 0 Jan 1 00:00 port2 > drwxr-xr-x 2 root root 0 Jan 1 00:00 port5 > drwxr-xr-x 2 root root 0 Jan 1 00:00 port6 > >Future patches will add entry files to these directories. > >Signed-off-by: Vivien Didelot Oh no, no debugfs please! What do you need to expose? I'm sure we can find out some generic, well defined and reusable way.