Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751190AbdH1Txg (ORCPT ); Mon, 28 Aug 2017 15:53:36 -0400 Received: from mail-wr0-f176.google.com ([209.85.128.176]:38042 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbdH1Txe (ORCPT ); Mon, 28 Aug 2017 15:53:34 -0400 Date: Mon, 28 Aug 2017 21:53:32 +0200 From: Jiri Pirko To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Andrew Lunn , Egil Hjelmeland , John Crispin , Woojung Huh , Sean Wang , Nikita Yushchenko , Chris Healy , mlxsw@mellanox.com Subject: Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Message-ID: <20170828195332.GB1950@nanopsycho.orion> References: <20170828191748.19492-1-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170828191748.19492-1-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 15 Mon, Aug 28, 2017 at 09:17:38PM CEST, vivien.didelot@savoirfairelinux.com wrote: >This patch series adds a generic debugfs interface for the DSA >framework, so that all switch devices benefit from it, e.g. Marvell, >Broadcom, Microchip or any other DSA driver. > >This is really convenient for debugging, especially CPU ports and DSA >links which are not exposed to userspace as net device. This interface >is currently the only way to easily inspect the hardware for such ports. > >With the patch series, any switch device user is able to query the >hardware for the supported tagging protocol, the ports stats and >registers, as well as their FDB, MDB and VLAN entries. I see this overlaps a lot with DPIPE. Why won't you use that to expose your hw state?