Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751322AbdH1UIq (ORCPT ); Mon, 28 Aug 2017 16:08:46 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:41882 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbdH1UIo (ORCPT ); Mon, 28 Aug 2017 16:08:44 -0400 Date: Mon, 28 Aug 2017 22:08:34 +0200 From: Andrew Lunn To: Jiri Pirko Cc: Vivien Didelot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Egil Hjelmeland , John Crispin , Woojung Huh , Sean Wang , Nikita Yushchenko , Chris Healy , mlxsw@mellanox.com Subject: Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Message-ID: <20170828200834.GA1870@lunn.ch> References: <20170828191748.19492-1-vivien.didelot@savoirfairelinux.com> <20170828195332.GB1950@nanopsycho.orion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170828195332.GB1950@nanopsycho.orion> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 19 > I see this overlaps a lot with DPIPE. Why won't you use that to expose > your hw state? We took a look at dpipe and i talked to you about using it for this sort of thing at netconf/netdev. But dpipe has issues displaying the sort of information we have. I never figured out how to do two dimensional tables. The output of the dpipe command is pretty unreadable. A lot of the information being dumped here is not about the data pipe, etc. There is a lot of pushback on debugfs for individual drivers. As i said recently to somebody, debugfs is a bit of a wild west. When designing this code, we thought about that. This debugfs is not at the driver level. It is at the DSA level. All DSA drivers will benefit from this code, and all DSA drivers will get the same information exposed in debugfs. It is generic, well defined and structured, with respect to DSA. Andrew