Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbdH1VwQ (ORCPT ); Mon, 28 Aug 2017 17:52:16 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:33588 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbdH1VwM (ORCPT ); Mon, 28 Aug 2017 17:52:12 -0400 X-Google-Smtp-Source: ADKCNb6rhtMSokzfCQo+fQAL2V39TTdyq0jOF2NXw89lrPjFiZpk4ZNp8NZQE3xz+yp/+v+/f1VLxMVlE3RFfpWR13w= MIME-Version: 1.0 In-Reply-To: <1503956551.2841.70.camel@wdc.com> References: <1503956111-36652-1-git-send-email-keescook@chromium.org> <1503956111-36652-18-git-send-email-keescook@chromium.org> <1503956551.2841.70.camel@wdc.com> From: Kees Cook Date: Mon, 28 Aug 2017 14:52:10 -0700 X-Google-Sender-Auth: mUNBg_R8GnvSwRdrWZGqNl7EPCI Message-ID: Subject: Re: [PATCH v2 17/30] scsi: Define usercopy region in scsi_sense_cache slab cache To: Bart Van Assche Cc: "linux-kernel@vger.kernel.org" , "jejb@linux.vnet.ibm.com" , "linux-scsi@vger.kernel.org" , "linux-mm@kvack.org" , "kernel-hardening@lists.openwall.com" , "martin.petersen@oracle.com" , "dave@nullcore.net" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1149 Lines: 28 On Mon, Aug 28, 2017 at 2:42 PM, Bart Van Assche wrote: > On Mon, 2017-08-28 at 14:34 -0700, Kees Cook wrote: >> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c >> index f6097b89d5d3..f1c6bd56dd5b 100644 >> --- a/drivers/scsi/scsi_lib.c >> +++ b/drivers/scsi/scsi_lib.c >> @@ -77,14 +77,15 @@ int scsi_init_sense_cache(struct Scsi_Host *shost) >> if (shost->unchecked_isa_dma) { >> scsi_sense_isadma_cache = >> kmem_cache_create("scsi_sense_cache(DMA)", >> - SCSI_SENSE_BUFFERSIZE, 0, >> - SLAB_HWCACHE_ALIGN | SLAB_CACHE_DMA, NULL); >> + SCSI_SENSE_BUFFERSIZE, 0, >> + SLAB_HWCACHE_ALIGN | SLAB_CACHE_DMA, NULL); >> if (!scsi_sense_isadma_cache) >> ret = -ENOMEM; > > All this part of this patch does is to change source code indentation. Should > these changes really be included in this patch? I can certainly drop that hunk, but the existing alignment is really ugly. :) Happy to do whatever. -Kees -- Kees Cook Pixel Security