Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751332AbdH1Wxf (ORCPT ); Mon, 28 Aug 2017 18:53:35 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:50486 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbdH1Wxd (ORCPT ); Mon, 28 Aug 2017 18:53:33 -0400 Date: Mon, 28 Aug 2017 15:53:33 -0700 (PDT) Message-Id: <20170828.155333.1067566141697358468.davem@davemloft.net> To: himanshujha199640@gmail.com Cc: jarod@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: broadcom: Remove null check before kfree From: David Miller In-Reply-To: <1503778667-4416-1-git-send-email-himanshujha199640@gmail.com> References: <1503778667-4416-1-git-send-email-himanshujha199640@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 28 Aug 2017 15:53:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 233 Lines: 8 From: Himanshu Jha Date: Sun, 27 Aug 2017 01:47:47 +0530 > Kfree on NULL pointer is a no-op and therefore checking is redundant. > > Signed-off-by: Himanshu Jha Applied.