Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751333AbdH1Xeq (ORCPT ); Mon, 28 Aug 2017 19:34:46 -0400 Received: from mail-bn3nam01on0139.outbound.protection.outlook.com ([104.47.33.139]:11584 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751189AbdH1Xep (ORCPT ); Mon, 28 Aug 2017 19:34:45 -0400 From: Ryan Lee To: Mark Brown CC: "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "kuninori.morimoto.gx@renesas.com" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "ryan.lee.maxim@gmail.com" Subject: RE: [PATCH 1/9] ASoC: max98927: Added TDM support Thread-Topic: [PATCH 1/9] ASoC: max98927: Added TDM support Thread-Index: AQHTHgQO7tLhp+oehkWjedvpbKcgaaKYPj8AgAIyJ5A= Date: Mon, 28 Aug 2017 23:34:41 +0000 Message-ID: References: <1503708070-7906-1-git-send-email-ryans.lee@maximintegrated.com> <20170827140238.bqav6pkpxd2yogch@sirena.org.uk> In-Reply-To: <20170827140238.bqav6pkpxd2yogch@sirena.org.uk> Accept-Language: en-US, ko-KR Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=RyanS.Lee@maximintegrated.com; x-originating-ip: [204.17.143.20] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY2PR11MB0597;6:/sjA96yKRkE0UmaDtCgDMsbyNCHtkRe3kBQRzPa3tfsMrJ94jFGnX6WGqq4xr6rXf5iwNq+OgPfDaQQhJTH5fwhFu7bDuXB6ZU6muZupvmmLSTWYXNPkWtjoaA7QNTuh634YQKSzk4pk29ximvNYMgb/DK/jC2OV4wHJe6x/FY1wgAGI9MLxcgK0I0fd3WauzeBcORSjkVbzzvt9R21L6w+k34OyFSChLuKJZgCN8tYzCoPgTF2xUFrgUEpMImk3hqPAiBFs710xpnmzYiQi1Bf7m+lfmeN2u+SHXkZ8i7pN94nqmB/FWGZg8Ah1tFdZFXduEzlYX7dGbXJ6kxwdvQ==;5:tKgz5VYYNEulxlvcvogZW68a4Zemcr7vgJ4i8rpKdhdW45OqaElRfragIksiWdRmN8GMw3CoelSSS1BieHYrAEyzVgFblJ7lSYug33c5SaIOo123y4LJ6sIPkbZ/Lz+UPe6kS4SfjH5miTPxwuPoGw==;24:rK1dAocUaPjcJDpAOkc0efsDKh1xTbs4Lr6VUOthPhrGKpzKS4gRcotPvXZuB8NODwzU5iubqHLs1OhzoMARTwnfXn9Y/lUvvqI3PonmXXw=;7:OHg/NbZSAJnkXz7kFRkIZM1GcPSLDCWCve8GZuumHG2f8atrcvj2K/Q8yGyZt/5Js3Sd7sOYjj9Wwu7JqtD/r0JyGiVwCEXVasXupD9u2moI/SeaUFpGz2qGVfw+S7t3Iu+A6IBfZEWaT8P18S2RxhA+KZCuwX29U5y+REcOmiGPDbi85jftrTyvIp6DCFOPzw4HXG88W4sLHU+5/wU+8CiLlnFtYQruxdxOph8U7f0= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: a01d574c-e7a2-4de5-2b4e-08d4ee6d5b24 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BY2PR11MB0597; x-ms-traffictypediagnostic: BY2PR11MB0597: x-exchange-antispam-report-test: UriScan:(108721460000369); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR11MB0597;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR11MB0597; x-forefront-prvs: 0413C9F1ED x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(24454002)(189002)(54534003)(199003)(478600001)(189998001)(229853002)(9686003)(8936002)(68736007)(4326008)(99286003)(86362001)(77096006)(105586002)(97736004)(7736002)(5660300001)(2900100001)(101416001)(6436002)(66066001)(55016002)(305945005)(7696004)(6506006)(14454004)(2906002)(50986999)(3846002)(39060400002)(72206003)(76176999)(54356999)(106356001)(54906002)(6116002)(102836003)(6246003)(2950100002)(3660700001)(81156014)(8676002)(6916009)(3280700002)(25786009)(53936002)(110136004)(81166006)(74316002)(33656002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR11MB0597;H:BY2PR11MB0837.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: maximintegrated.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2017 23:34:41.2150 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fbd909df-ea69-4788-a554-f24b7854ad03 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR11MB0597 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7SNYofR032090 Content-Length: 881 Lines: 26 >Subject: Re: [PATCH 1/9] ASoC: max98927: Added TDM support > >On Fri, Aug 25, 2017 at 05:41:02PM -0700, Ryan Lee wrote: >> Signed-off-by: Ryan Lee > >This says it's adding support for TDM mode but... > >> + case SND_SOC_DAIFMT_DSP_A: >> + format = MAX98927_PCM_FORMAT_TDM_MODE1; >> + break; >> + case SND_SOC_DAIFMT_DSP_B: >> + format = MAX98927_PCM_FORMAT_TDM_MODE0; >> + break; >> case SND_SOC_DAIFMT_PDM: >> - max98927->iface |= SND_SOC_DAIFMT_PDM; >> + use_pdm = true; >> break; > >...it looks like it's adding support for two new DSP modes and generally making a >bunch of other changes. This probably needs splitting up, or at least a bit more >of a changelog. I wanted to split this patch but changes were all about DSP_A and DSP_B format support. I added more description about this patch and send patch series again.