Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751276AbdH2EWz (ORCPT ); Tue, 29 Aug 2017 00:22:55 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:54522 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbdH2EWx (ORCPT ); Tue, 29 Aug 2017 00:22:53 -0400 Date: Mon, 28 Aug 2017 21:22:52 -0700 (PDT) Message-Id: <20170828.212252.121365416573053421.davem@davemloft.net> To: yanhaishuang@cmss.chinamobile.com Cc: sathya.perla@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] be2net: Fix some u16 fields appropriately From: David Miller In-Reply-To: <979AB2E6-7D90-4C6B-B43F-1D17EE621D05@cmss.chinamobile.com> References: <1503818685-32068-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <20170828.161924.1286298670313299855.davem@davemloft.net> <979AB2E6-7D90-4C6B-B43F-1D17EE621D05@cmss.chinamobile.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 28 Aug 2017 21:22:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7T4N4Bu017623 Content-Length: 429 Lines: 13 From: 严海双 Date: Tue, 29 Aug 2017 09:04:57 +0800 > The GET_TX_COMPL_BITS comes from amap_get which also returns a 32-bit value: It never returns a value with more than 16-bits of significance for this specific call. Please stop trying to be semantically clever when arguing about this change. It's not about types, it's about what range of values the struct member can actually hold.