Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751271AbdH2G3g (ORCPT ); Tue, 29 Aug 2017 02:29:36 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36142 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbdH2G3e (ORCPT ); Tue, 29 Aug 2017 02:29:34 -0400 Date: Tue, 29 Aug 2017 08:29:31 +0200 From: Jiri Pirko To: David Miller Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch, privat@egil-hjelmeland.no, john@phrozen.org, Woojung.Huh@microchip.com, sean.wang@mediatek.com, nikita.yoush@cogentembedded.com, cphealy@gmail.com Subject: Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Message-ID: <20170829062931.GB1977@nanopsycho.orion> References: <20170828191748.19492-1-vivien.didelot@savoirfairelinux.com> <20170828.213837.1354872205076475221.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170828.213837.1354872205076475221.davem@davemloft.net> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1277 Lines: 28 Tue, Aug 29, 2017 at 06:38:37AM CEST, davem@davemloft.net wrote: >From: Vivien Didelot >Date: Mon, 28 Aug 2017 15:17:38 -0400 > >> This patch series adds a generic debugfs interface for the DSA >> framework, so that all switch devices benefit from it, e.g. Marvell, >> Broadcom, Microchip or any other DSA driver. > >I've been thinking this over and I agree with the feedback given that >debugfs really isn't appropriate for this. > >Please create a DSA device class, and hang these values under >appropriate sysfs device nodes that can be easily found via >/sys/class/dsa/ just as easily as they would be /sys/kernel/debug/dsa/ > >You really intend these values to be consistent across DSA devices, >and you don't intend to go willy-nilly changig these exported values >arbitrarily over time. That's what debugfs is for, throw-away >stuff. > >So please make these proper device sysfs attributes rather than >debugfs. As I wrote, I believe that there is a big overlap with devlink and its dpipe subset. I think that primary we should focus on extending whatever is needed for dsa there. The iface should be generic for all drivers, not only dsa. dsa-specific sysfs attributes should be last-resort solution, I believe we can avoid them.