Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751258AbdH2IIf (ORCPT ); Tue, 29 Aug 2017 04:08:35 -0400 Received: from canardo.mork.no ([148.122.252.1]:44349 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbdH2IIb (ORCPT ); Tue, 29 Aug 2017 04:08:31 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Johan Hovold Cc: "Maciej S. Szmigiero" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: add support for D-Link DWM-157 C1 Organization: m References: <20170828101939.GD20634@localhost> <7dd41245-8822-2038-86a1-bbcb393521e7@maciej.szmigiero.name> <20170829074108.GG20634@localhost> Date: Tue, 29 Aug 2017 10:08:13 +0200 In-Reply-To: <20170829074108.GG20634@localhost> (Johan Hovold's message of "Tue, 29 Aug 2017 09:41:08 +0200") Message-ID: <87ziai4x02.fsf@miraculix.mork.no> User-Agent: Gnus/5.130015 (Ma Gnus v0.15) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7T88df3031823 Content-Length: 2005 Lines: 46 Johan Hovold writes: > On Mon, Aug 28, 2017 at 04:32:53PM +0200, Maciej S. Szmigiero wrote: > >> Also, three other D-Link modems few lines above are using the same >> USB_DEVICE_AND_INTERFACE_INFO() selectors. > > Yeah, I noticed those, and I'm not sure why they're not using > class-matching only either (and note that we have some entries that do). I see that I'm responsible for those. They can probably be compressed to USB_DEVICE_INTERFACE_CLASS(). I assume I just didn't think about it... FWIW, I found this 'devices' listing for the 2001:7d01 device. I believe the 7d02 and 7d03 are similar: P: Vendor=2001 ProdID=7d01 Rev= 3.00 S: Manufacturer=D-Link,Inc S: Product=D-Link DWM-156 C:* #Ifs= 7 Cfg#= 1 Atr=a0 MxPwr=500mA A: FirstIf#= 0 IfCount= 2 Cls=02(comm.) Sub=0e Prot=00 I:* If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=0e Prot=00 Driver=cdc_mbim E: Ad=88(I) Atr=03(Int.) MxPS= 64 Ivl=125us I: If#= 1 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim I:* If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=02 Prot=01 Driver=option E: Ad=87(I) Atr=03(Int.) MxPS= 64 Ivl=500us E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms I:* If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms I:* If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms I:* If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms I:* If#= 6 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms Bjørn