Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751399AbdH2IkL (ORCPT ); Tue, 29 Aug 2017 04:40:11 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:21335 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbdH2IkF (ORCPT ); Tue, 29 Aug 2017 04:40:05 -0400 From: Gabriel FERNANDEZ To: Philipp Zabel , "linux-kernel@vger.kernel.org" CC: Alexandru Gagniuc , Andre Przywara , Maxime Coquelin , Alexandre TORGUE , Maxime Ripard , Chen-Yu Tsai , Baoyou Xie , Eugeniy Paltsev , Steffen Trumtrar , Dinh Nguyen , =?utf-8?B?QW5kcmVhcyBGw6RyYmVy?= , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" Subject: Re: [v3,3/5] reset: stm32: use the reset-simple driver Thread-Topic: [v3,3/5] reset: stm32: use the reset-simple driver Thread-Index: AQHTIKJJEF72//mglE+joCHaDKt75w== Date: Tue, 29 Aug 2017 08:39:12 +0000 Message-ID: <79cc2d75-4d48-754c-a0a6-b51e0c8a81bc@st.com> References: <20170816094701.30678-4-p.zabel@pengutronix.de> In-Reply-To: <20170816094701.30678-4-p.zabel@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.46] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-29_02:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7T8eI0X031989 Content-Length: 6035 Lines: 179 On 08/16/2017 11:46 AM, Philipp Zabel wrote: > The reset-simple driver can be used without changes. > > Signed-off-by: Philipp Zabel > Reviewed-by: Alexandru Gagniuc > --- > drivers/reset/Kconfig | 11 ++--- > drivers/reset/Makefile | 1 - > drivers/reset/reset-simple.c | 1 + > drivers/reset/reset-stm32.c | 108 ------------------------------------------- > 4 files changed, 4 insertions(+), 117 deletions(-) > delete mode 100644 drivers/reset/reset-stm32.c > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > index 78a8f6057985b..29f4487c290fc 100644 > --- a/drivers/reset/Kconfig > +++ b/drivers/reset/Kconfig > @@ -70,19 +70,14 @@ config RESET_PISTACHIO > > config RESET_SIMPLE > bool "Simple Reset Controller Driver" if COMPILE_TEST > - default ARCH_SOCFPGA || ARCH_SUNXI > + default ARCH_SOCFPGA || ARCH_STM32 || ARCH_SUNXI > help > This enables a simple reset controller driver for reset lines that > that can be asserted and deasserted by toggling bits in a contiguous, > exclusive register space. > > - Currently this driver supports Altera SoCFPGAs and Allwinner SoCs. > - > -config RESET_STM32 > - bool "STM32 Reset Driver" if COMPILE_TEST > - default ARCH_STM32 > - help > - This enables the RCC reset controller driver for STM32 MCUs. > + Currently this driver supports Altera SoCFPGAs, the RCC reset > + controller in STM32 MCUs, and Allwinner SoCs. > > config RESET_SUNXI > bool "Allwinner SoCs Reset Driver" if COMPILE_TEST && !ARCH_SUNXI > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile > index 25f5f722dec01..e8c3a032f4780 100644 > --- a/drivers/reset/Makefile > +++ b/drivers/reset/Makefile > @@ -12,7 +12,6 @@ obj-$(CONFIG_RESET_MESON) += reset-meson.o > obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o > obj-$(CONFIG_RESET_PISTACHIO) += reset-pistachio.o > obj-$(CONFIG_RESET_SIMPLE) += reset-simple.o > -obj-$(CONFIG_RESET_STM32) += reset-stm32.o > obj-$(CONFIG_RESET_SUNXI) += reset-sunxi.o > obj-$(CONFIG_RESET_TI_SCI) += reset-ti-sci.o > obj-$(CONFIG_RESET_TI_SYSCON) += reset-ti-syscon.o > diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c > index 84b08ce4def01..e54a29b8b532d 100644 > --- a/drivers/reset/reset-simple.c > +++ b/drivers/reset/reset-simple.c > @@ -120,6 +120,7 @@ static const struct reset_simple_devdata reset_simple_active_low = { > > static const struct of_device_id reset_simple_dt_ids[] = { > { .compatible = "altr,rst-mgr", .data = &reset_simple_socfpga }, > + { .compatible = "st,stm32-rcc", }, > { .compatible = "allwinner,sun6i-a31-clock-reset", > .data = &reset_simple_active_low }, > { /* sentinel */ }, > diff --git a/drivers/reset/reset-stm32.c b/drivers/reset/reset-stm32.c > deleted file mode 100644 > index 3a7c8527e66af..0000000000000 > --- a/drivers/reset/reset-stm32.c > +++ /dev/null > @@ -1,108 +0,0 @@ > -/* > - * Copyright (C) Maxime Coquelin 2015 > - * Author: Maxime Coquelin > - * License terms: GNU General Public License (GPL), version 2 > - * > - * Heavily based on sunxi driver from Maxime Ripard. > - */ > - > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > -struct stm32_reset_data { > - spinlock_t lock; > - void __iomem *membase; > - struct reset_controller_dev rcdev; > -}; > - > -static int stm32_reset_assert(struct reset_controller_dev *rcdev, > - unsigned long id) > -{ > - struct stm32_reset_data *data = container_of(rcdev, > - struct stm32_reset_data, > - rcdev); > - int bank = id / BITS_PER_LONG; > - int offset = id % BITS_PER_LONG; > - unsigned long flags; > - u32 reg; > - > - spin_lock_irqsave(&data->lock, flags); > - > - reg = readl(data->membase + (bank * 4)); > - writel(reg | BIT(offset), data->membase + (bank * 4)); > - > - spin_unlock_irqrestore(&data->lock, flags); > - > - return 0; > -} > - > -static int stm32_reset_deassert(struct reset_controller_dev *rcdev, > - unsigned long id) > -{ > - struct stm32_reset_data *data = container_of(rcdev, > - struct stm32_reset_data, > - rcdev); > - int bank = id / BITS_PER_LONG; > - int offset = id % BITS_PER_LONG; > - unsigned long flags; > - u32 reg; > - > - spin_lock_irqsave(&data->lock, flags); > - > - reg = readl(data->membase + (bank * 4)); > - writel(reg & ~BIT(offset), data->membase + (bank * 4)); > - > - spin_unlock_irqrestore(&data->lock, flags); > - > - return 0; > -} > - > -static const struct reset_control_ops stm32_reset_ops = { > - .assert = stm32_reset_assert, > - .deassert = stm32_reset_deassert, > -}; > - > -static const struct of_device_id stm32_reset_dt_ids[] = { > - { .compatible = "st,stm32-rcc", }, > - { /* sentinel */ }, > -}; > - > -static int stm32_reset_probe(struct platform_device *pdev) > -{ > - struct stm32_reset_data *data; > - struct resource *res; > - > - data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); > - if (!data) > - return -ENOMEM; > - > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - data->membase = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(data->membase)) > - return PTR_ERR(data->membase); > - > - spin_lock_init(&data->lock); > - > - data->rcdev.owner = THIS_MODULE; > - data->rcdev.nr_resets = resource_size(res) * 8; > - data->rcdev.ops = &stm32_reset_ops; > - data->rcdev.of_node = pdev->dev.of_node; > - > - return devm_reset_controller_register(&pdev->dev, &data->rcdev); > -} > - > -static struct platform_driver stm32_reset_driver = { > - .probe = stm32_reset_probe, > - .driver = { > - .name = "stm32-rcc-reset", > - .of_match_table = stm32_reset_dt_ids, > - }, > -}; > -builtin_platform_driver(stm32_reset_driver); Acked-by: Gabriel Fernandez