Subject: Re: [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2
 implementation defined pmu core events
To: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
References: <20170824120349.2323-1-ganapatrao.kulkarni@cavium.com>
 <20170824120349.2323-5-ganapatrao.kulkarni@cavium.com>
CC: <Will.Deacon@arm.com>, <catalin.marinas@arm.com>,
        <mark.rutland@arm.com>, <acme@kernel.org>,
        <alexander.shishkin@linux.intel.com>, <peterz@infradead.org>,
        <mingo@redhat.com>, <jnair@caviumnetworks.com>,
        <Jonathan.Cameron@huawei.com>, <Robert.Richter@cavium.com>,
        <gklkml16@gmail.com>
From: Zhangshaokun <zhangshaokun@hisilicon.com>
Message-ID: <43dcc107-263a-5429-73d4-a5290c6610d6@hisilicon.com>
Date: Tue, 29 Aug 2017 17:26:00 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <20170824120349.2323-5-ganapatrao.kulkarni@cavium.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3998
Lines: 112


Hi Ganapat,

On 2017/8/24 20:03, Ganapatrao Kulkarni wrote:
> This is not a full event list, but a short list of useful events.
> 
> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> ---
>  tools/perf/pmu-events/arch/arm64/mapfile.csv       | 15 ++++++
>  .../arm64/thunderx2/implementation-defined.json    | 62 ++++++++++++++++++++++
>  2 files changed, 77 insertions(+)
>  create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv
>  create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json
> 

I saw you also used thunderx2 in tools/perf/pmu-events/arch/arm64/, how about John's suggestion
that would use vendor sub-folder?
Of course, appreciate maintainer's comments.

Thanks,
Shaokun

> diff --git a/tools/perf/pmu-events/arch/arm64/mapfile.csv b/tools/perf/pmu-events/arch/arm64/mapfile.csv
> new file mode 100644
> index 0000000..7167086
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/mapfile.csv
> @@ -0,0 +1,15 @@
> +# Format:
> +#	MIDR,Version,JSON/file/pathname,Type
> +#
> +# where
> +#	MIDR	Processor version
> +#		Variant[23:20] and Revision [3:0] should be zero.
> +#	Version could be used to track version of of JSON file
> +#		but currently unused.
> +#	JSON/file/pathname is the path to JSON file, relative
> +#		to tools/perf/pmu-events/arch/arm64/.
> +#	Type is core, uncore etc
> +#
> +#
> +#Family-model,Version,Filename,EventType
> +0x00000000420f5160,v1,thunderx2,core
> diff --git a/tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json b/tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json
> new file mode 100644
> index 0000000..2db45c4
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json
> @@ -0,0 +1,62 @@
> +[
> +    {
> +        "PublicDescription": "Attributable Level 1 data cache access, read",
> +        "EventCode": "0x40",
> +        "EventName": "l1d_cache_rd",
> +        "BriefDescription": "L1D cache read",
> +    },
> +    {
> +        "PublicDescription": "Attributable Level 1 data cache access, write ",
> +        "EventCode": "0x41",
> +        "EventName": "l1d_cache_wr",
> +        "BriefDescription": "L1D cache write",
> +    },
> +    {
> +        "PublicDescription": "Attributable Level 1 data cache refill, read",
> +        "EventCode": "0x42",
> +        "EventName": "l1d_cache_refill_rd",
> +        "BriefDescription": "L1D cache refill read",
> +    },
> +    {
> +        "PublicDescription": "Attributable Level 1 data cache refill, write",
> +        "EventCode": "0x43",
> +        "EventName": "l1d_cache_refill_wr",
> +        "BriefDescription": "L1D refill write",
> +    },
> +    {
> +        "PublicDescription": "Attributable Level 1 data TLB refill, read",
> +        "EventCode": "0x4C",
> +        "EventName": "l1d_tlb_refill_rd",
> +        "BriefDescription": "L1D tlb refill read",
> +    },
> +    {
> +        "PublicDescription": "Attributable Level 1 data TLB refill, write",
> +        "EventCode": "0x4D",
> +        "EventName": "l1d_tlb_refill_wr",
> +        "BriefDescription": "L1D tlb refill write",
> +    },
> +    {
> +        "PublicDescription": "Attributable Level 1 data or unified TLB access, read",
> +        "EventCode": "0x4E",
> +        "EventName": "l1d_tlb_rd",
> +        "BriefDescription": "L1D tlb read",
> +    },
> +    {
> +        "PublicDescription": "Attributable Level 1 data or unified TLB access, write",
> +        "EventCode": "0x4F",
> +        "EventName": "l1d_tlb_wr",
> +        "BriefDescription": "L1D tlb write",
> +    },
> +    {
> +        "PublicDescription": "Bus access read",
> +        "EventCode": "0x60",
> +        "EventName": "bus_access_rd",
> +        "BriefDescription": "Bus access read",
> +   },
> +   {
> +        "PublicDescription": "Bus access write",
> +        "EventCode": "0x61",
> +        "EventName": "bus_access_wr",
> +        "BriefDescription": "Bus access write",
> +   }
> +]
>