Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754017AbdH2QMe (ORCPT ); Tue, 29 Aug 2017 12:12:34 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35869 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752826AbdH2QMd (ORCPT ); Tue, 29 Aug 2017 12:12:33 -0400 MIME-Version: 1.0 In-Reply-To: <20170829090130.m5zarou3t3tjfjlf@hirez.programming.kicks-ass.net> References: <20170823115843.662056844@infradead.org> <20170823121432.990701317@infradead.org> <20170829064637.GC3240@X58A-UD3R> <20170829090130.m5zarou3t3tjfjlf@hirez.programming.kicks-ass.net> From: Byungchul Park Date: Wed, 30 Aug 2017 01:12:31 +0900 Message-ID: Subject: Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation To: Peter Zijlstra Cc: Byungchul Park , Ingo Molnar , Tejun Heo , Boqun Feng , david@fromorbit.com, johannes@sipsolutions.net, oleg@redhat.com, "linux-kernel@vger.kernel.org" , kernel-team@lge.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 19 On Tue, Aug 29, 2017 at 6:01 PM, Peter Zijlstra wrote: > On Tue, Aug 29, 2017 at 03:46:38PM +0900, Byungchul Park wrote: > >> How does a maintainer choose a very work-around method and avoid >> problems rather than fix a root cause? I am very disappointed. > > Time.. we need this sorted before we push the whole lot to Linus in the > next window. Fixing the recursive-read thing is far more work (although > Boqun did post some patches for that, which I still have to look at). As I said, it's not a problem of whether read-acquire should be used or not, of course I thought so, for the first time. But now I see what problems are, as I already answered to TJ. The work which makes read-acquire work well is worth itself. But, problems we should focus on now is that manual acquire(work, wq) should be replaced with others or removed. -- Thanks, Byungchul