Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752685AbdH2Pxv (ORCPT ); Tue, 29 Aug 2017 11:53:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36020 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbdH2Pxt (ORCPT ); Tue, 29 Aug 2017 11:53:49 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 15CDB85376 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Tue, 29 Aug 2017 10:53:44 -0500 From: Josh Poimboeuf To: Joe Lawrence Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu , Jiri Kosina , Miroslav Benes , Petr Mladek , Chris J Arges Subject: Re: [PATCH v4 2/3] livepatch: move transition "complete" notice into klp_complete_transition() Message-ID: <20170829155344.p4ncfsddax5pkuoo@treble> References: <1503688202-12121-1-git-send-email-joe.lawrence@redhat.com> <1503688202-12121-3-git-send-email-joe.lawrence@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1503688202-12121-3-git-send-email-joe.lawrence@redhat.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 29 Aug 2017 15:53:49 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 620 Lines: 16 On Fri, Aug 25, 2017 at 03:10:01PM -0400, Joe Lawrence wrote: > klp_complete_transition() performs a bit of housework before a > transition to KLP_PATCHED or KLP_UNPATCHED is actually completed > (including post-(un)patch callbacks). To be consistent, move the > transition "complete" kernel log notice out of > klp_try_complete_transition() and into klp_complete_transition(). > > Signed-off-by: Joe Lawrence > Suggested-by: Josh Poimboeuf I think the Signed-off-by should always be the last line. Otherwise: Acked-by: Josh Poimboeuf -- Josh