Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455AbdH2Osq (ORCPT ); Tue, 29 Aug 2017 10:48:46 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35682 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbdH2Oso (ORCPT ); Tue, 29 Aug 2017 10:48:44 -0400 Date: Tue, 29 Aug 2017 16:48:50 +0200 From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: driverdevel , Samuel Ortiz , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Stefano Brivio , "David S. Miller" Subject: Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it Message-ID: <20170829144850.GC22532@kroah.com> References: <20170827150334.32495-1-gregkh@linuxfoundation.org> <20170829131131.6e11c8f9@elisabeth> <20170829112805.GB14571@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1505 Lines: 41 On Tue, Aug 29, 2017 at 02:11:39PM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Tue, Aug 29, 2017 at 1:28 PM, Greg Kroah-Hartman > wrote: > > On Tue, Aug 29, 2017 at 01:11:31PM +0200, Stefano Brivio wrote: > >> On Tue, 29 Aug 2017 12:59:00 +0200 > >> Geert Uytterhoeven wrote: > >> > On Sun, Aug 27, 2017 at 5:03 PM, Greg Kroah-Hartman > >> > wrote: > >> > > The IRDA code has long been obsolete and broken. So, to keep people > >> > > from trying to use it, and to prevent people from having to maintain it, > >> > > let's move it to drivers/staging/ so that we can delete it entirely from > >> > > the kernel in a few releases. > >> > > >> > (diving into an early boot crash) > >> > > >> > Have you tried running this? ;-) > >> > > >> > irda_init() and net_dev_init() are both subsys_initcall()s. > >> > But the former now runs before the latter, leading to: > >> > > >> > Unable to handle kernel NULL pointer dereference at virtual address 00000004 > >> > >> Should be fixed by https://patchwork.ozlabs.org/patch/807006/ > >> ("[net-next] staging: irda: force to be a kernel module") I guess... > > > > Yup, that's the fix for this issue. > > > > Geert, does that fix the problem for you? > > Thanks, that patch fixes the crash, obviously. > > It does mean you can no longer have IrDA in a non-modular kernel. Given that irda doesn't really work, I doubt anyone is going to care about it :) thanks, greg k-h