Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753604AbdH2MLm (ORCPT ); Tue, 29 Aug 2017 08:11:42 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:37979 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752863AbdH2MLk (ORCPT ); Tue, 29 Aug 2017 08:11:40 -0400 MIME-Version: 1.0 In-Reply-To: <20170829112805.GB14571@kroah.com> References: <20170827150334.32495-1-gregkh@linuxfoundation.org> <20170829131131.6e11c8f9@elisabeth> <20170829112805.GB14571@kroah.com> From: Geert Uytterhoeven Date: Tue, 29 Aug 2017 14:11:39 +0200 X-Google-Sender-Auth: tl4m5hixmkLELY1EAoP3WNk0VU0 Message-ID: Subject: Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it To: Greg Kroah-Hartman Cc: Stefano Brivio , driverdevel , Samuel Ortiz , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1613 Lines: 44 Hi Greg, On Tue, Aug 29, 2017 at 1:28 PM, Greg Kroah-Hartman wrote: > On Tue, Aug 29, 2017 at 01:11:31PM +0200, Stefano Brivio wrote: >> On Tue, 29 Aug 2017 12:59:00 +0200 >> Geert Uytterhoeven wrote: >> > On Sun, Aug 27, 2017 at 5:03 PM, Greg Kroah-Hartman >> > wrote: >> > > The IRDA code has long been obsolete and broken. So, to keep people >> > > from trying to use it, and to prevent people from having to maintain it, >> > > let's move it to drivers/staging/ so that we can delete it entirely from >> > > the kernel in a few releases. >> > >> > (diving into an early boot crash) >> > >> > Have you tried running this? ;-) >> > >> > irda_init() and net_dev_init() are both subsys_initcall()s. >> > But the former now runs before the latter, leading to: >> > >> > Unable to handle kernel NULL pointer dereference at virtual address 00000004 >> >> Should be fixed by https://patchwork.ozlabs.org/patch/807006/ >> ("[net-next] staging: irda: force to be a kernel module") I guess... > > Yup, that's the fix for this issue. > > Geert, does that fix the problem for you? Thanks, that patch fixes the crash, obviously. It does mean you can no longer have IrDA in a non-modular kernel. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds