Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754148AbdH2OGh (ORCPT ); Tue, 29 Aug 2017 10:06:37 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:43141 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752410AbdH2OGf (ORCPT ); Tue, 29 Aug 2017 10:06:35 -0400 Date: Tue, 29 Aug 2017 16:06:25 +0200 From: Andrew Lunn To: Corentin Labbe Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, f.fainelli@gmail.com, alexandre.torgue@st.com, netdev@vger.kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, peppe.cavallaro@st.com, maxime.ripard@free-electrons.com, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io Subject: Re: [PATCH v4 4/5] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated Message-ID: <20170829140625.GA8235@lunn.ch> References: <20170826073311.25612-1-clabbe.montjoie@gmail.com> <20170826073311.25612-5-clabbe.montjoie@gmail.com> <20170826212051.GA10418@lunn.ch> <20170829083432.GA28818@Red> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170829083432.GA28818@Red> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 263 Lines: 7 > Do you agree that another mdio_mux_init() must be written ? (taking > a of_node (in our case: mdio-mux) instead of a device) Yes, you are correct, it is using dev->of_node. So you need to refactor the code a little, to allow an of_node to be passed. Andrew