Subject: Re: [PATCH] drm/amd: Remove null check before kfree
To: Himanshu Jha <himanshujha199640@gmail.com>, airlied@linux.ie
Cc: alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <1504012887-15147-1-git-send-email-himanshujha199640@gmail.com>
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <a04969d0-f2a7-7720-f77b-5f997c23a18b@amd.com>
Date: Tue, 29 Aug 2017 15:28:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1504012887-15147-1-git-send-email-himanshujha199640@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2017 13:28:19.7895 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1308
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1760
Lines: 47

Am 29.08.2017 um 15:21 schrieb Himanshu Jha:
> Kfree on NULL pointer is a no-op and therefore checking is redundant.
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c     | 6 ++----
>   drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 6 ++----
>   2 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> index 8d1cf2d..f51b41f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> @@ -346,10 +346,8 @@ static void amdgpu_connector_free_edid(struct drm_connector *connector)
>   {
>   	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
>   
> -	if (amdgpu_connector->edid) {
> -		kfree(amdgpu_connector->edid);
> -		amdgpu_connector->edid = NULL;
> -	}
> +	kfree(amdgpu_connector->edid);
> +	amdgpu_connector->edid = NULL;
>   }
>   
>   static int amdgpu_connector_ddc_get_modes(struct drm_connector *connector)
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
> index 76347ff..00075c2 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
> @@ -606,10 +606,8 @@ int smu7_init(struct pp_smumgr *smumgr)
>   
>   int smu7_smu_fini(struct pp_smumgr *smumgr)
>   {
> -	if (smumgr->backend) {
> -		kfree(smumgr->backend);
> -		smumgr->backend = NULL;
> -	}
> +	kfree(smumgr->backend);
> +	smumgr->backend = NULL;
>   	cgs_rel_firmware(smumgr->device, CGS_UCODE_ID_SMU);
>   	return 0;
>   }