Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753203AbdH2Pan (ORCPT ); Tue, 29 Aug 2017 11:30:43 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:38298 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434AbdH2Pal (ORCPT ); Tue, 29 Aug 2017 11:30:41 -0400 Date: Tue, 29 Aug 2017 08:30:37 -0700 From: Tejun Heo To: David Ahern Cc: Christoph Hellwig , linux-ide@vger.kernel.org, LKML , Robert Elliott Subject: Re: boot failure with 4.13.0-rc6 due to ATA errors Message-ID: <20170829153037.GN491396@devbig577.frc2.facebook.com> References: <3117ae58-d432-101e-3f0b-68d72fdee28b@gmail.com> <20170828195916.GA491396@devbig577.frc2.facebook.com> <37033f6d-2ad0-7817-10b5-cbd7ff565624@gmail.com> <20170828212225.GB491396@devbig577.frc2.facebook.com> <20170829124206.GA26738@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 888 Lines: 22 On Tue, Aug 29, 2017 at 09:08:05AM -0600, David Ahern wrote: > On 8/29/17 6:42 AM, Christoph Hellwig wrote: > > --- > > From e661047ec3a25587648b07c02a687a7dac778f3b Mon Sep 17 00:00:00 2001 > > From: Christoph Hellwig > > Date: Tue, 29 Aug 2017 14:35:50 +0200 > > Subject: libata: check for trusted computing in IDENTIFY DEVICE data > > > > ATA-8 and later mirrors the TRUSTED COMPUTING SUPPORTED bit in word 48 of > > the IDENTIFY DEVICE data. Check this before issuing a READ LOG PAGE > > command to avoid issues with buggy devices. The only downside is that > > we can't support Security Send / Receive for a device with an older > > revision due to the conflicting use of this field in earlier > > specifications. Christoph, I'm gonna revert the horkage patch and apply this one. If you can think of a better way to do this, please let me know. Thanks. -- tejun