DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 08B446147F
Date: Tue, 29 Aug 2017 17:36:32 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: Yang Zhang <yang.zhang.wz@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>, Wanpeng Li <wanpeng.li@hotmail.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Radim Krcmar <rkrcmar@redhat.com>, David Matlack <dmatlack@google.com>,
        Alexander Graf <agraf@suse.de>, Peter Zijlstra <peterz@infradead.org>,
        linux-doc@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/7] x86/idle: add halt poll support
Message-ID: <20170829172929-mutt-send-email-mst@kernel.org>
References: <1504007201-12904-1-git-send-email-yang.zhang.wz@gmail.com>
 <CANRm+CzrNVNcoM5MWwcGbzBF+ZU=Z7ibhFL_9V3RcPjsuPSTgw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANRm+CzrNVNcoM5MWwcGbzBF+ZU=Z7ibhFL_9V3RcPjsuPSTgw@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 823
Lines: 19

On Tue, Aug 29, 2017 at 10:02:15PM +0800, Wanpeng Li wrote:
> Actually I'm not sure how much sense it makes to introduce this pv
> stuff and the duplicate adaptive halt-polling logic as what has
> already been done in kvm w/o obvious benefit for real workload like
> netperf.

In fact, I would really like to better understand why does the polling
in kvm even help.  Switching to the idle task is supposed to be really
cheap as you are not losing context.  In case of e.g. network polling
you gain the interrupt latency, but in case of kvm it's just an IPI
which is converted to a memory write when using mwait. Is mwait more
costly than commonly thought? Or is the idle driver too agressive in
putting the CPU into deep sleep?

I think this analysis is something that would benefit
bare-metal/containers as well.

-- 
MST