Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751904AbdH2QtP (ORCPT ); Tue, 29 Aug 2017 12:49:15 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35070 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631AbdH2QtN (ORCPT ); Tue, 29 Aug 2017 12:49:13 -0400 Date: Tue, 29 Aug 2017 09:49:12 -0700 (PDT) Message-Id: <20170829.094912.1121803194631886017.davem@davemloft.net> To: gregkh@linuxfoundation.org Cc: geert@linux-m68k.org, devel@driverdev.osuosl.org, samuel@sortiz.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sbrivio@redhat.com Subject: Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it From: David Miller In-Reply-To: <20170829144850.GC22532@kroah.com> References: <20170829112805.GB14571@kroah.com> <20170829144850.GC22532@kroah.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Aug 2017 09:49:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1698 Lines: 43 From: Greg Kroah-Hartman Date: Tue, 29 Aug 2017 16:48:50 +0200 > On Tue, Aug 29, 2017 at 02:11:39PM +0200, Geert Uytterhoeven wrote: >> Hi Greg, >> >> On Tue, Aug 29, 2017 at 1:28 PM, Greg Kroah-Hartman >> wrote: >> > On Tue, Aug 29, 2017 at 01:11:31PM +0200, Stefano Brivio wrote: >> >> On Tue, 29 Aug 2017 12:59:00 +0200 >> >> Geert Uytterhoeven wrote: >> >> > On Sun, Aug 27, 2017 at 5:03 PM, Greg Kroah-Hartman >> >> > wrote: >> >> > > The IRDA code has long been obsolete and broken. So, to keep people >> >> > > from trying to use it, and to prevent people from having to maintain it, >> >> > > let's move it to drivers/staging/ so that we can delete it entirely from >> >> > > the kernel in a few releases. >> >> > >> >> > (diving into an early boot crash) >> >> > >> >> > Have you tried running this? ;-) >> >> > >> >> > irda_init() and net_dev_init() are both subsys_initcall()s. >> >> > But the former now runs before the latter, leading to: >> >> > >> >> > Unable to handle kernel NULL pointer dereference at virtual address 00000004 >> >> >> >> Should be fixed by https://patchwork.ozlabs.org/patch/807006/ >> >> ("[net-next] staging: irda: force to be a kernel module") I guess... >> > >> > Yup, that's the fix for this issue. >> > >> > Geert, does that fix the problem for you? >> >> Thanks, that patch fixes the crash, obviously. >> >> It does mean you can no longer have IrDA in a non-modular kernel. > > Given that irda doesn't really work, I doubt anyone is going to care > about it :) The initialization with everything built-in worked fine before your changes.