Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751243AbdH2R2g (ORCPT ); Tue, 29 Aug 2017 13:28:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51778 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbdH2R2f (ORCPT ); Tue, 29 Aug 2017 13:28:35 -0400 Date: Tue, 29 Aug 2017 19:28:40 +0200 From: Greg KH To: harsha Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG() Message-ID: <20170829172840.GA5335@kroah.com> References: <1504027194-6973-1-git-send-email-harshasharmaiitr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504027194-6973-1-git-send-email-harshasharmaiitr@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2249 Lines: 60 On Tue, Aug 29, 2017 at 10:49:54PM +0530, harsha wrote: > Signed-off-by: harsha > --- > drivers/staging/android/ion/ion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 93e2c90..a2d36b3 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -66,7 +66,7 @@ static void ion_buffer_add(struct ion_device *dev, > p = &(*p)->rb_right; > } else { > pr_err("%s: buffer already found.", __func__); > - BUG(); > + WARN_ON(); > } > } > > -- > 1.9.1 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. - You did not use your real name. Signed-off-by: and From: has to have a real name associated with it. Use whatever you sign legal documents with, no anonymous patches are allowed. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot