Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751412AbdH2TY2 (ORCPT ); Tue, 29 Aug 2017 15:24:28 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:38606 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750822AbdH2TY0 (ORCPT ); Tue, 29 Aug 2017 15:24:26 -0400 Date: Tue, 29 Aug 2017 20:00:15 +0100 From: Mark Brown To: Ryan Lee Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, kuninori.morimoto.gx@renesas.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ryan.lee.maxim@gmail.com Subject: Re: [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B format Message-ID: <20170829190015.kpscn3uuwbvwlp6e@sirena.org.uk> References: <1503963061-14763-1-git-send-email-ryans.lee@maximintegrated.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="euhoxbrlqmbpsmvn" Content-Disposition: inline In-Reply-To: <1503963061-14763-1-git-send-email-ryans.lee@maximintegrated.com> X-Cookie: Often things ARE as bad as they seem! User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 35 --euhoxbrlqmbpsmvn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 28, 2017 at 04:30:53PM -0700, Ryan Lee wrote: > + if ((max98927->iface == SND_SOC_DAIFMT_DSP_A) || > + (max98927->iface == SND_SOC_DAIFMT_DSP_B)) > + return 0; > + > + /* BCLK configuration */ Why do we not configure the BCLK in DSP modes? That's unusual and seems likely to break some systems that rely on exact clocking. Also if we're selecting on format a switch statement is generally better to make any further special casing easier in future. --euhoxbrlqmbpsmvn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmlub8ACgkQJNaLcl1U h9ATgwgAg7A9FD5vNeKfNbMaPuGscSKHWiIlwzXlpaDCS09BPMKQaIU03LIQ6/47 Qgg2Mf5WPY+c4TPwebR9a1+6m5wUPKf1p6fsY7lCCqCyBhIuvTjI2nPHtotY6Frh waKFm4taKvAfQ+AkP1gUMX4sY9OrzRulUm+sxJdfwF09bmowV57/+EDtTvRvbCGI FarNEN7qfhIClAS/UVv+SbJ51Q8sX8JYj5HuigXMQO2PExt32zzaI3Owy+d/cO/e JR2q3cCjPx6SzNqgMXIxitJUPwSyhJ4l31A3kXjfdJ8hMTzGBEmk2SzvMJFf0W1i oC3+70UEJEBbvoJ804xxQFdPrrrJ+A== =CIKk -----END PGP SIGNATURE----- --euhoxbrlqmbpsmvn--