Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751507AbdH2TnV (ORCPT ); Tue, 29 Aug 2017 15:43:21 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:34775 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbdH2TnN (ORCPT ); Tue, 29 Aug 2017 15:43:13 -0400 MIME-Version: 1.0 In-Reply-To: References: <1504012887-15147-1-git-send-email-himanshujha199640@gmail.com> From: Alex Deucher Date: Tue, 29 Aug 2017 15:43:12 -0400 Message-ID: Subject: Re: [PATCH] drm/amd: Remove null check before kfree To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Himanshu Jha , Dave Airlie , "Deucher, Alexander" , Maling list - DRI developers , amd-gfx list , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7TJhNnI008261 Content-Length: 2209 Lines: 66 On Tue, Aug 29, 2017 at 9:28 AM, Christian König wrote: > Am 29.08.2017 um 15:21 schrieb Himanshu Jha: >> >> Kfree on NULL pointer is a no-op and therefore checking is redundant. >> >> Signed-off-by: Himanshu Jha > > > Reviewed-by: Christian König > Applied. thanks! Alex > >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 6 ++---- >> drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 6 ++---- >> 2 files changed, 4 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c >> index 8d1cf2d..f51b41f 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c >> @@ -346,10 +346,8 @@ static void amdgpu_connector_free_edid(struct >> drm_connector *connector) >> { >> struct amdgpu_connector *amdgpu_connector = >> to_amdgpu_connector(connector); >> - if (amdgpu_connector->edid) { >> - kfree(amdgpu_connector->edid); >> - amdgpu_connector->edid = NULL; >> - } >> + kfree(amdgpu_connector->edid); >> + amdgpu_connector->edid = NULL; >> } >> static int amdgpu_connector_ddc_get_modes(struct drm_connector >> *connector) >> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c >> b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c >> index 76347ff..00075c2 100644 >> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c >> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c >> @@ -606,10 +606,8 @@ int smu7_init(struct pp_smumgr *smumgr) >> int smu7_smu_fini(struct pp_smumgr *smumgr) >> { >> - if (smumgr->backend) { >> - kfree(smumgr->backend); >> - smumgr->backend = NULL; >> - } >> + kfree(smumgr->backend); >> + smumgr->backend = NULL; >> cgs_rel_firmware(smumgr->device, CGS_UCODE_ID_SMU); >> return 0; >> } > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx