Date: Fri, 4 Jul 2003 01:27:34 -0700
From: Andrew Morton <akpm@osdl.org>
To: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: wli@holomorphy.com, helgehaf@aitel.hist.no, zboszor@freemail.hu,
       linux-kernel@vger.kernel.org
Subject: Re: 2.5.74-mm1
Message-Id: <20030704012734.77f99e74.akpm@osdl.org>
In-Reply-To: <Pine.LNX.4.53.0307040307090.24383@montezuma.mastecende.com>
References: <3F0407D1.8060506@freemail.hu>
	<3F042AEE.2000202@freemail.hu>
	<20030703122243.51a6d581.akpm@osdl.org>
	<20030703200858.GA31084@hh.idb.hist.no>
	<20030703141508.796e4b82.akpm@osdl.org>
	<20030704055315.GW26348@holomorphy.com>
	<Pine.LNX.4.53.0307040307090.24383@montezuma.mastecende.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1030
Lines: 35

Zwane Mwaikambo <zwane@arm.linux.org.uk> wrote:
>

Changing this:

>  static inline void bitmap_or(volatile unsigned long *dst, const volatile unsigned long *bitmap1,
>  				const volatile unsigned long *bitmap2, int bits)
>  {
>  	int k;
> 
>  	for (k = 0; k < BITS_TO_LONGS(bits); ++k)
>  		dst[k] = bitmap1[k] | bitmap2[k];
>  }

to this:

static inline void bitmap_or(unsigned long *dst, unsigned long *bitmap1,
                                unsigned long *bitmap2, int bits)
{
        int k;
        int nr = BITS_TO_LONGS(bits);

        for (k = 0; k < nr; k++)
                dst[k] = bitmap1[k] | bitmap2[k];
}

fixes it up, and looks nicer anyway.  Removing the volatiles (what were
they doing there?) did not fix it.  The `nr' thing fixed it.  

I shall make that change.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/