Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751363AbdH2UUa (ORCPT ); Tue, 29 Aug 2017 16:20:30 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:34667 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbdH2UU2 (ORCPT ); Tue, 29 Aug 2017 16:20:28 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Liam Breck Date: Tue, 29 Aug 2017 13:20:27 -0700 X-Google-Sender-Auth: wZCycr1X-S-rnQ_zJ7Pb9YTS4yc Message-ID: Subject: Re: [PATCH resend v2] power: supply: bq27xxx: enable writing capacity values for bq27421 To: "H. Nikolaus Schaller" Cc: Sebastian Reichel , =?UTF-8?Q?Pali_Roh=C3=A1r?= , "Andrew F. Davis" , linux-pm@vger.kernel.org, linux-kernel , Discussions about the Letux Kernel , kernel@pyra-handheld.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 882 Lines: 24 Hi Nikolaus, thanks for the patch... On Tue, Aug 29, 2017 at 1:10 PM, H. Nikolaus Schaller wrote: > Tested on Pyra prototype with bq27421. > > Signed-off-by: H. Nikolaus Schaller > --- > drivers/power/supply/bq27xxx_battery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c > index b6c3120ca5ad..e3c878ef7c7e 100644 > --- a/drivers/power/supply/bq27xxx_battery.c > +++ b/drivers/power/supply/bq27xxx_battery.c > @@ -688,7 +688,7 @@ static struct bq27xxx_dm_reg bq27545_dm_regs[] = { > #define bq27545_dm_regs 0 > #endif > > -#if 0 /* not yet tested */ > +#if 1 /* tested on Pyra */ > static struct bq27xxx_dm_reg bq27421_dm_regs[] = { I think we can drop the #if and #else...#endif so it's just the dm_regs table, as with bq27425.