Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751519AbdH2Ugk (ORCPT <rfc822;w@1wt.eu>);
        Tue, 29 Aug 2017 16:36:40 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:34501 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751250AbdH2Ugi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 Aug 2017 16:36:38 -0400
Date: Tue, 29 Aug 2017 23:36:08 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: harsha <harshasharmaiitr@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than
 BUG()
Message-ID: <20170829203608.mdstdicxgpidps64@mwanda>
References: <1504034462-13195-1-git-send-email-harshasharmaiitr@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1504034462-13195-1-git-send-email-harshasharmaiitr@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 546
Lines: 15

On Wed, Aug 30, 2017 at 12:51:01AM +0530, harsha wrote:
> Hi,
> harsha,  this is my real name.

That's your full name that you use to sign legal documents?  No last
name? No capital letter at the beginning?

> There is no need to call BUG() over here as this error is not very basic and BUG() tends to bring the system down so calling WARN_ON() is preferable.

In the original code the kernel will call BUG() once but in the new code
it will spam the dmesg forever until you pull the power cord.  There is
no improvement.

regards,
dan carpenter