Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbdH2XOM (ORCPT ); Tue, 29 Aug 2017 19:14:12 -0400 Received: from mail-by2nam01on0121.outbound.protection.outlook.com ([104.47.34.121]:13120 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751514AbdH2XOK (ORCPT ); Tue, 29 Aug 2017 19:14:10 -0400 From: Long Li To: Pavel Shilovsky CC: Steve French , linux-cifs , samba-technical , Kernel Mailing List , "linux-rdma@vger.kernel.org" , Christoph Hellwig , "Tom Talpey" , Matthew Wilcox Subject: RE: [Patch v3 04/19] CIFS: SMBD: Add SMBDirect transport to SMB connection and Makefile Thread-Topic: [Patch v3 04/19] CIFS: SMBD: Add SMBDirect transport to SMB connection and Makefile Thread-Index: AQHTIP1P+uWyBGN3bEqqHKb8W8GCb6Kb9m6AgAAAhYA= Date: Tue, 29 Aug 2017 23:14:08 +0000 Message-ID: References: <20170829192915.26251-1-longli@exchange.microsoft.com> <20170829192915.26251-5-longli@exchange.microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=longli@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-29T16:14:06.5877804-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:c::735] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR21MB0478;6:q2G2uLL13vWq4PVyQmL3+qha+rmKWdjo/NjoX6ZUzf1Pib+aUkDRlb9sZ9fL8ZpoX6dIIh6sj4+vfD6NUVrOmsFDRz+Zdgn4VUCMqAaqrTYhHG82v6bdS+krK80PczLpN883GPGq3bVtYnWwoYUQW0nsBfqu0xj9xrRoj8riZECS9ZoTth0f3atCa0ZamueLu2pwo5t0vMV5sACx36yi8fvIDyta1BLiFdcbOX26a/LDFh7YFiRon6DSxlTtkeg7D1y6vx7aACc8f/uelB2SCF+rsSR2tMmhwWElN5QGVfVGpiWGcdtI+i/W9fX6pAjTsCvC7nDD/qKBf8kcdRDNwQ==;5:Lcl4AV2M14BKF+aP9sKak0rKMAeZ0EGetl7G2PT85D0G8h1u0rxMMQC1RvRER6S8m/1Jb/qpobIIfDii2k4jYUkTrn6FuUPPmCOHrpEBurL9ptsdImaFJ+AhI7teSIcInvAap5rHSzXfm6UywDZARg==;24:llHwvVIpiMXHJPAVhPb4nCLqeycMngRx4ZWWiF6ojG0zz40rlrGRuu9PS93JKKWHcia66EauhPnLtixQTHrq1yNnFNSp1Dh8oCe0eSJAEjU=;7:ecgaM1p+pmkuUxN6cFmmcvfTrXHOeyk241zBI828ZL8UbKGAlhk52OJaTWoZqk+CT3Y1CIcWrUZV1WrH2DJonGbhdGGIAeA6TuwN4lLNUohE6GTpEwD7hHjZNy35l+bbb3crST5obCpQW6PY7679kwszvs+dG/ffKUDL6h5dpGrJdnllVok9k7q4iqSCUdj3wQIRC/5Sy87HsKPPulag1BSK47eC0PYTYMTQvZLwrK0= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 1f49ed9d-33d8-43af-c0d4-08d4ef33a698 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:MWHPR21MB0478; x-ms-traffictypediagnostic: MWHPR21MB0478: authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055)(189930954265078)(140211028294663)(219752817060721); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR21MB0478;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR21MB0478; x-forefront-prvs: 0414DF926F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(199003)(13464003)(377454003)(189002)(377424004)(53936002)(305945005)(86362001)(76176999)(54356999)(50986999)(1411001)(102836003)(33656002)(6116002)(99286003)(110136004)(107886003)(55016002)(54906002)(10290500003)(86612001)(478600001)(9686003)(6246003)(6306002)(101416001)(189998001)(39060400002)(7736002)(53546010)(8936002)(25786009)(8676002)(81156014)(81166006)(14454004)(229853002)(8990500004)(105586002)(106356001)(5005710100001)(4326008)(5660300001)(77096006)(7696004)(6436002)(6506006)(97736004)(3660700001)(68736007)(10090500001)(3280700002)(2900100001)(966005)(74316002)(2950100002)(6916009)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR21MB0478;H:MWHPR21MB0190.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2017 23:14:08.0513 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0478 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7TNEFfa022828 Content-Length: 3179 Lines: 85 > -----Original Message----- > From: Pavel Shilovsky [mailto:piastryyy@gmail.com] > Sent: Tuesday, August 29, 2017 4:12 PM > To: Long Li > Cc: Steve French ; linux-cifs cifs@vger.kernel.org>; samba-technical ; > Kernel Mailing List ; linux- > rdma@vger.kernel.org; Christoph Hellwig ; Tom Talpey > ; Matthew Wilcox ; > Long Li > Subject: Re: [Patch v3 04/19] CIFS: SMBD: Add SMBDirect transport to SMB > connection and Makefile > > 2017-08-29 12:29 GMT-07:00 Long Li : > > From: Long Li > > > > Add SMBDirect as an optional connection to the SMB session structure in > CIFS. > > When SMB session is connected through SMBDirect, upper layer uses this > > connection to carry payloads. > > > > With the transport code hooked up to upper layer, add SMBDirect code > > to Makefile. > > > > Signed-off-by: Long Li > > --- > > fs/cifs/Makefile | 2 +- > > fs/cifs/cifsglob.h | 2 ++ > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/fs/cifs/Makefile b/fs/cifs/Makefile index > > eed7eb0..6bb9863 100644 > > --- a/fs/cifs/Makefile > > +++ b/fs/cifs/Makefile > > @@ -18,4 +18,4 @@ cifs-$(CONFIG_CIFS_DFS_UPCALL) += dns_resolve.o > > cifs_dfs_ref.o > > cifs-$(CONFIG_CIFS_FSCACHE) += fscache.o cache.o > > > > cifs-$(CONFIG_CIFS_SMB2) += smb2ops.o smb2maperror.o > smb2transport.o \ > > - smb2misc.o smb2pdu.o smb2inode.o smb2file.o > > + smb2misc.o smb2pdu.o smb2inode.o > > + smb2file.o smbdirect.o > > diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h index > > 703c2fb..dc5404d 100644 > > --- a/fs/cifs/cifsglob.h > > +++ b/fs/cifs/cifsglob.h > > @@ -652,6 +652,8 @@ struct TCP_Server_Info { > > bool large_buf; /* is current buffer large? */ > > /* use SMBD connection instead of socket */ > > bool rdma; > > + /* point to the SMBD connection if RDMA is used instead of socket */ > > + struct smbd_connection *smbd_conn; > > struct delayed_work echo; /* echo ping workqueue job */ > > char *smallbuf; /* pointer to current "small" buffer */ > > char *bigbuf; /* pointer to current "big" buffer */ > > -- > > 2.7.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-cifs" > > in the body of a message to majordomo@vger.kernel.org More > majordomo > > info at > > > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.k > > ernel.org%2Fmajordomo- > info.html&data=02%7C01%7Clongli%40microsoft.com% > > > 7C74a459a67c6440f88d4308d4ef3358c5%7C72f988bf86f141af91ab2d7cd011db > 47% > > > 7C1%7C0%7C636396451192818334&sdata=nIFmV5wvnL1xMm6tCnfdAgLMt% > 2BFKJU6oh > > hNhEXO8ZJs%3D&reserved=0 > > It is better to split the current patch into 2 and merge the Makefile part to #3 > and cifsglob.h part to #5. Sure, will make the change. > > -- > Best regards, > Pavel Shilovsky