Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbdH3AL3 (ORCPT ); Tue, 29 Aug 2017 20:11:29 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:36821 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbdH3AL0 (ORCPT ); Tue, 29 Aug 2017 20:11:26 -0400 MIME-Version: 1.0 In-Reply-To: <20170829235447.10050-1-jglisse@redhat.com> References: <20170829235447.10050-1-jglisse@redhat.com> From: Linus Torvalds Date: Tue, 29 Aug 2017 17:11:24 -0700 X-Google-Sender-Auth: 3j0AVxg8tZ5zPsC2ayjdYoFOhS0 Message-ID: Subject: Re: [PATCH 00/13] mmu_notifier kill invalidate_page callback To: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Bernhard Held , Adam Borowski Cc: Linux Kernel Mailing List , linux-mm , "Kirill A . Shutemov" , Andrew Morton , Andrea Arcangeli , Joerg Roedel , Dan Williams , Sudeep Dutt , Ashutosh Dixit , Dimitri Sivanich , Jack Steiner , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , ppc-dev , DRI , amd-gfx@lists.freedesktop.org, "linux-rdma@vger.kernel.org" , "open list:AMD IOMMU (AMD-VI)" , xen-devel , KVM list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7U0BXi6026410 Content-Length: 1471 Lines: 39 On Tue, Aug 29, 2017 at 4:54 PM, Jérôme Glisse wrote: > > Note this is barely tested. I intend to do more testing of next few days > but i do not have access to all hardware that make use of the mmu_notifier > API. Thanks for doing this. > First 2 patches convert existing call of mmu_notifier_invalidate_page() > to mmu_notifier_invalidate_range() and bracket those call with call to > mmu_notifier_invalidate_range_start()/end(). Ok, those two patches are a bit more complex than I was hoping for, but not *too* bad. And the final end result certainly looks nice: > 16 files changed, 74 insertions(+), 214 deletions(-) Yeah, removing all those invalidate_page() notifiers certainly makes for a nice patch. And I actually think you missed some more lines that can now be removed: kvm_arch_mmu_notifier_invalidate_page() should no longer be needed either, so you can remove all of those too (most of them are empty inline functions, but x86 has one that actually does something. So there's an added 30 or so dead lines that should be removed in the kvm patch, I think. But from a _very_ quick read-through this looks fine. But it obviously needs testing. People - *especially* the people who saw issues under KVM - can you try out Jérôme's patch-series? I aded some people to the cc, the full series is on lkml. Jérôme - do you have a git branch for people to test that they could easily pull and try out? Linus